[GitHub] incubator-carbondata pull request #352: [CARBONDATA-448] Solve compilation e...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/352

    [CARBONDATA-448] Solve compilation error in core for spark2

    Solve compilation error in core for spark2, after this PR, master can be compile with -Pspark-2.0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata internalrow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
   
----
commit 54f0ea5b6da13718fc72a171810cc0a3bfe31d08
Author: jackylk <[hidden email]>
Date:   2016-11-25T02:11:23Z

    make -Pspark-2.0 compilable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/352
 
    CI passed
    http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/654/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user scwf commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/352#discussion_r89570118
 
    --- Diff: pom.xml ---
    @@ -291,27 +286,36 @@
           </activation>
           <properties>
             <spark.version>1.5.2</spark.version>
    +        <scala.binary.version>2.10</scala.binary.version>
    +        <scala.version>2.10.4</scala.version>
           </properties>
           <modules>
             <module>integration/spark</module>
    +        <module>examples/spark</module>
    --- End diff --
   
    should also include spark common module


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/352#discussion_r89570719
 
    --- Diff: pom.xml ---
    @@ -291,27 +286,36 @@
           </activation>
           <properties>
             <spark.version>1.5.2</spark.version>
    +        <scala.binary.version>2.10</scala.binary.version>
    +        <scala.version>2.10.4</scala.version>
           </properties>
           <modules>
             <module>integration/spark</module>
    +        <module>examples/spark</module>
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/352


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---