[GitHub] incubator-carbondata pull request #357: [CARBONDATA-451]Fix the bug of store...

[qiuchenjian-2]

GitHub user Zhangshunyu opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/357

    [CARBONDATA-451]Fix the bug of storePath.substring on windows which lead to query can not run

    ## Why rasie this pr?
    To fix the bug that when query execute on windows can not run, this is becasue when table path is got on windows, the patch might contains '\' but current code substring the path not format it.
    ## How to solve?
    Using the formatted table path.
    ## How to test?
    Pass all the test cases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Zhangshunyu/incubator-carbondata path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #357
   
----
commit 3443686e8df8791fbb92af55608ee90aa874faf8
Author: Zhangshunyu <[hidden email]>
Date:   2016-11-26T10:22:22Z

    Fix the bug of storePath substring on windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user Zhangshunyu commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/357
 
    @jackylk pls review this pr, thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/357
 
    @Zhangshunyu ...LGMT....only thing is you can put some comments with example for better understanding like what can be tablePath and derived formattedTablePath.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/357
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user Zhangshunyu commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/357
 
    Added comments and rebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/357


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---