[GitHub] incubator-carbondata pull request #368: [CARBONDATA-465] Spark streaming dat...

[qiuchenjian-2]

Github user allwefantasy commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/368#discussion_r91218797
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala ---
    @@ -308,3 +310,155 @@ class NewCarbonDataLoadRDD[K, V](
         }
       }
     }
    +
    --- End diff --
   
    Comments have been added for NewDataFrameLoaderRDD and NewRddIterator


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/368
 
    Build Success, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/56/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/368
 
    Build Success, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/57/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/368#discussion_r91284355
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -604,4 +606,33 @@ public static boolean isHeaderValid(String tableName, String header,
         }
         return dateformatsHashMap;
       }
    +
    --- End diff --
   
    Please remove this reflection code and try to set from RDD like how it was doing in CarbonDataLoadRDD


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/368#discussion_r91284876
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -763,10 +763,9 @@ case class LoadTable(
     
     
           val columinar = sqlContext.getConf("carbon.is.columnar.storage", "true").toBoolean
    -      val kettleHomePath = CarbonScalaUtil.getKettleHome(sqlContext)
     
           // TODO It will be removed after kettle is removed.
    -      val useKettle = options.get("use_kettle") match {
    +      val useKettle = options.get("useKettle") match {
    --- End diff --
   
    I think it does not work if it executes from parser, please make it consistent across all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/368
 
    LGTM, Good work.
    But few comments like reflection is not required(can set context from initialize from RDD ) are not addressed, we can fix them in another PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/368


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---