[GitHub] incubator-carbondata pull request #391: [CARBONDATA-374] support smallint

[qiuchenjian-2]

GitHub user cenyuhai opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/391

    [CARBONDATA-374] support smallint

    **What changes were proposed in this pull request?**
   
    support smallint type
   
    **How to test？**
    Test with TestCreateTable.scala

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cenyuhai/incubator-carbondata CARBON-374

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #391
   
----
commit 9e238a441576f93f2b7bc5e85a72c99c0b138130
Author: cenyuhai <[hidden email]>
Date:   2016-12-04T10:17:44Z

    support smallint

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user cenyuhai commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/391
 
    @jackylk @lion-x pls review the codes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/391
 
    @cenyuhai There is one testcase failing, please fix it.
    http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/748/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/391
 
    错误信息如下：
    **Regression**
    org.apache.carbondata.core.util.DataTypeUtilTest.testGetDataType
   
    Failing for the past 1 build (Since Unstable#748 )
    运行时间：3 毫秒
    Error Message
   
    expected:<SHORT> but was:<STRING>
    Stacktrace
   
    junit.framework.AssertionFailedError: expected:<SHORT> but was:<STRING>
    at junit.framework.Assert.fail(Assert.java:57)
    at junit.framework.Assert.failNotEquals(Assert.java:329)
    at junit.framework.Assert.assertEquals(Assert.java:78)
    at junit.framework.Assert.assertEquals(Assert.java:86)
    at junit.framework.TestCase.assertEquals(TestCase.java:253)
    at org.apache.carbondata.core.util.DataTypeUtilTest.testGetDataType(DataTypeUtilTest.java:82)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user cenyuhai commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/391
 
    @ravipesala @chenliang613


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/391
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/391


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---