GitHub user abhisheknoldus opened a pull request:
https://github.com/apache/incubator-carbondata/pull/399 [CARBONDATA-494] Added unit test cases for scan.filter.executer package Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[CARBONDATA-<Jira issue #>] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - What manual testing you have done? - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/abhisheknoldus/incubator-carbondata filter.executer_unit_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/399.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #399 ---- commit 36e41e91ae545fc3ad13aab7d5e3d98f7537ec80 Author: abhishek <[hidden email]> Date: 2016-11-10T06:54:06Z AndFilterExecuterImpl test commit cf2d83deeee333399c8305eefc41096de9c8a618 Author: abhishek <[hidden email]> Date: 2016-11-10T07:41:26Z OrFilterExecuterImpl test commit f5a49f2d9a2442bf7c73d1a9b98b63488e3761c9 Author: abhishek <[hidden email]> Date: 2016-11-23T14:55:18Z class formatted and RowLevelFilterExecuterImpl unit test commit 97650d8ca6f543301b67127ae0462316546afc91 Author: harmeetsingh0013 <[hidden email]> Date: 2016-11-24T05:29:03Z Add unit test cases for RowLevelRangeGrtrThanEquaToFilterExecuterImplTest ExcludeFilterExecuterImplTest ExcludeColGroupFilterExecuterImplTest commit a0a0704d6a6507620a9cc63f08396e8e1b812ab1 Author: harmeetsingh0013 <[hidden email]> Date: 2016-11-24T10:39:10Z Add rules FilterExecutorTestRule for code resuable and add unit test cases for RowLevelRangeGrtThanFiterExecuterImplTest commit 373fa3541590b4bde9a5eeaf3ea1ad1e8acf48d2 Author: harmeetsingh0013 <[hidden email]> Date: 2016-11-28T06:55:28Z Write unit test cases for IncludeFilterExecuterImpl java class commit cb85ec5b87989cc36f548e46f8e40fa5185ad66d Author: abhishek <[hidden email]> Date: 2016-11-29T08:04:20Z restructureFilterExecuterImpl unit test and class formatted commit acb3626249d4b1bba773c4eb70910905e0cc5873 Author: abhishek <[hidden email]> Date: 2016-11-29T08:05:40Z RowLevelRangeLessThanEqualFilterExecuterImpl unit test commit fce7ff55179556fefc688b523fdde985e71e4659 Author: abhishek <[hidden email]> Date: 2016-11-29T08:06:51Z RowLevelRangeLessThanFilterExecuterImpl unit test. commit 223695d5344c35eb401277c068682957ccc3a5ab Author: harmeetsingh0013 <[hidden email]> Date: 2016-11-29T09:54:11Z Add unit test case for IncludeColGroupFilterExecuterImpl commit d3f57105067de90635cf39ac8377d55563c37d8c Author: abhishek <[hidden email]> Date: 2016-12-01T07:59:19Z RowLevelRangeTypeExecuterFacory unit test commit da992b50070906172f0425b55eb30d9b57419a8c Author: abhishek <[hidden email]> Date: 2016-12-02T05:41:18Z values changed as per method name commit cf08888f7e97cfc2fa9e2ea6427d0766e75b77a6 Author: abhishek <[hidden email]> Date: 2016-12-02T15:40:00Z unit test case file with correct package format commit 725cf47247fa297c3735e52f8a669f081ca58dde Author: harmeetsingh0013 <[hidden email]> Date: 2016-12-05T06:25:10Z rebase from master and fix issues commit 32604bb8005c6c1b07d0c7a3093a3b6d59e306d5 Author: harmeetsingh0013 <[hidden email]> Date: 2016-12-05T09:32:23Z mock SegmentProperties getColumnGroupMdKeyOrdinal method commit b9b8e2d8ba98bbd0f667e2fc4355e7c033da1936 Author: abhishek <[hidden email]> Date: 2016-12-05T11:50:10Z test case resolved and class formatted commit 6222e0212a5ff38d09be7c717a7dc7ed6fc84886 Author: abhishek <[hidden email]> Date: 2016-12-05T12:04:30Z apache license added ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/399 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/399 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/399 Build Success, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/33/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/399 @abhisheknoldus Please don't add any binary files like include.carbondata --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/399 Build Failed with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/146/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/399 Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/181/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user abhisheknoldus commented on the issue:
https://github.com/apache/incubator-carbondata/pull/399 @ravipesala I have done the changes in test cases. Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user abhisheknoldus closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Free forum by Nabble | Edit this page |