[GitHub] incubator-carbondata pull request #432: [CARBONDATA-531] remove spark depend...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/432

    [CARBONDATA-531] remove spark dependency in carbon core

    Carbon-core module should not depend on spark, this PR removes this dependency

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata core

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #432
   
----
commit 525fdf580ca2fe307c6c71105a0f2044b36d4ede
Author: jackylk <[hidden email]>
Date:   2016-12-13T16:25:01Z

    remove spark dependency in carbon core

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/432
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/162/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/432#discussion_r92554824
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonScan.scala ---
    @@ -151,8 +153,15 @@ case class CarbonScan(
     
             override def next(): InternalRow = {
               val value = iter.next
    +          val converted = value.map {
    --- End diff --
   
    understood, I will wait for the performance check in cluster environment before reworking on this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/432
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/518/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/432
 
    This PR has too many conflict, I will close it and raise it again


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/432


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---