[GitHub] incubator-carbondata pull request #445: [CARBONDATA-543] Write unit test cas...

[qiuchenjian-2]

GitHub user harmeetsingh0013 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/445

    [CARBONDATA-543] Write unit test cases for DataBlockIteratorImpl, IntermediateFileMerger and SortDataRows classes

    Implements unit test cases for  DataBlockIteratorImpl, IntermediateFileMerger and SortDataRows classes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/harmeetsingh0013/incubator-carbondata CARBONDATA-543

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #445
   
----
commit 94898cc916244dca7f3aa3ed16d3b2c777997839
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-09T13:40:13Z

    add unit test cases for IntermediateFileMerger with 75% coverrage

commit f2b6f71332e9eb5cd398d28e2f040f445a01938a
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-09T14:07:45Z

    add unit test cases with 77% coverrage

commit e53247b3679e122c2bb564ba9e908b8ca2aea31f
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-09T14:28:33Z

    add unit test cases for IntermediateFileMerger with 87% coverrage

commit 74186efef14fca8c891c5ed0762e6a20adf890a1
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-09T14:42:45Z

    add unit test cases for IntermediateFileMerger with 91% coverrage

commit 25eb40e71b975115b4f65e92b7f3628ea172aae0
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-13T13:35:22Z

    create temp data files

commit 440d3658aa2d49ed5be406c26e5edc7e982e4bc5
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-14T06:39:59Z

    add test case class for SortDataRows class

commit 6162cdf12c33a93e029344dbdecd68472174f664
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-16T10:03:15Z

    write unit test case of SortDataRows with 85% test coverage

commit 9cbb8eaeba01627ff63f0a29af60b0487e230d5e
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-19T06:37:51Z

    write unit test cases for DataBlockIteratorImpl

commit b0fe427f676977ce079cc6e8326933f4cdaa388e
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-12-19T07:34:42Z

    -resolve unit test case issue after rebase

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/445
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/235/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user harmeetsingh0013 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/445
 
    Hello @ravipesala please review this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/445
 
    I do not think adding unit test for these internal class are good practice, because these class will change easily when adding new features. We should be adding test case for writing and reading CarbonData files (file level features) or loading and query tables (table level features)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user harmeetsingh0013 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---