[GitHub] incubator-carbondata pull request #453: [CARBONDATA-549] code improvements f...

[qiuchenjian-2]

GitHub user JihongMA opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/453

    [CARBONDATA-549] code improvements for bigint, decimal value compression

    misc code changes for bigint, decimal value compression
   
    mvn clean verify -- successful


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JihongMA/incubator-carbondata CARBONDATA-549

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #453
   
----
commit 1241ada35d3463eee2c9850590792b72bca4c416
Author: Jihong Ma <[hidden email]>
Date:   2016-12-13T00:31:12Z

    Merge remote-tracking branch 'upstream/master'

commit 0bf1fb35c79f0fe12cc0e61a8b6c53b51085bdcc
Author: Jihong Ma <[hidden email]>
Date:   2016-12-20T01:55:53Z

    Merge remote-tracking branch 'upstream/master'

commit dda23a5142f9b4438a18718aa63df45a795bc448
Author: Jihong Ma <[hidden email]>
Date:   2016-12-20T01:59:52Z

    rebase with master

commit 9ec212669003ea41edc1c99f26e9ef289f9d4867
Author: Jihong Ma <[hidden email]>
Date:   2016-12-21T19:59:45Z

    code cleanup for bigint compression

commit a8f6a5f757a28bd2a8b272cfb71b2bee37ec03e6
Author: Jihong Ma <[hidden email]>
Date:   2016-12-21T20:31:01Z

    Merge branch 'CARBONDATA-549' of https://github.com/JihongMA/incubator-carbondata into localbranch

commit 62c1a80942c46c4be51ba75da150e0e95f28704e
Author: Jihong Ma <[hidden email]>
Date:   2016-12-21T23:26:35Z

    minor fix

commit 5d811cb867657aeb4813960cc2f8c412fc0c6839
Author: Jihong Ma <[hidden email]>
Date:   2016-12-21T23:51:12Z

    style fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user JihongMA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user JihongMA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    add to whitelist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    add to whitelist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/283/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/453#discussion_r93667932
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/WriterCompressModel.java ---
    @@ -88,15 +88,15 @@ public void setCompType(ValueCompressionUtil.COMPRESSION_TYPE[] compType) {
       /**
        * @return the changedDataType
    --- End diff --
   
    Please change the comment as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    LGTM except small comment,  Thanks for refactoring the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/292/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/453
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/453


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---