[GitHub] incubator-carbondata pull request #473: [CARBONDATA-569] clean up code for c...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/473

    [CARBONDATA-569] clean up code for carbon-processing module

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata cleanprocess

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #473
   
----
commit 2c7829060b9e049ceafc9dc940ac368bf927936a
Author: jackylk <[hidden email]>
Date:   2016-12-27T17:37:36Z

    wip

commit 856c7cad87895dfe49830906e1c8fcd938fda0bc
Author: jackylk <[hidden email]>
Date:   2016-12-27T18:02:26Z

    clean up unused declare

commit 4335af1f0e4a4f306915758b8cd9bdeb7092cd86
Author: jackylk <[hidden email]>
Date:   2016-12-27T18:09:38Z

    fix style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/473
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/347/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/473#discussion_r94002674
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/api/dataloader/SchemaInfo.java ---
    @@ -98,54 +98,26 @@ public String getSrcDriverName() {
       }
     
       /**
    -   * @param srcDriverName The srcDriverName to set.
    -   */
    -  public void setSrcDriverName(String srcDriverName) {
    -    this.srcDriverName = srcDriverName;
    -  }
    -
    -  /**
        * @return Returns the srcConUrl.
        */
       public String getSrcConUrl() {
    --- End diff --
   
    Please clear all get methods also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/473#discussion_r94003843
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java ---
    @@ -44,11 +44,6 @@
       String getName();
    --- End diff --
   
    need delete setName() method also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/473#discussion_r94008979
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/api/dataloader/SchemaInfo.java ---
    @@ -98,54 +98,26 @@ public String getSrcDriverName() {
       }
     
       /**
    -   * @param srcDriverName The srcDriverName to set.
    -   */
    -  public void setSrcDriverName(String srcDriverName) {
    -    this.srcDriverName = srcDriverName;
    -  }
    -
    -  /**
        * @return Returns the srcConUrl.
        */
       public String getSrcConUrl() {
    --- End diff --
   
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/473#discussion_r94008992
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java ---
    @@ -44,11 +44,6 @@
       String getName();
    --- End diff --
   
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/473
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/353/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/473
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/358/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/473


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---