[GitHub] incubator-carbondata pull request #480: [Carbondata 390] float data type sup...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/480

    [Carbondata 390] float data type supported

    Float data type supported with spark 1.6 and spark 2.0.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-390

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #480
   
----
commit e4b8ef8d821fed469749b0704c56ef839210aeb9
Author: rahulforallp <[hidden email]>
Date:   2016-12-29T07:36:50Z

    float supported with spark 2

commit 3cd12966b2848435cbab62bbde393a6495f13779
Author: rahulforallp <[hidden email]>
Date:   2016-12-29T08:01:32Z

    code refactored

commit dc770f513767a3c4d89f5e96967c7e591f727182
Author: rahulforallp <[hidden email]>
Date:   2016-12-29T10:10:35Z

    example added for float datatype

commit 43c2697214370fcc3b8c279095e00b5e120df265
Author: rahulforallp <[hidden email]>
Date:   2016-12-29T10:21:59Z

    unnecessary code removed

commit 0ced1353d908255eaf0bf695b4321b61c255fd02
Author: rahulforallp <[hidden email]>
Date:   2016-12-29T11:29:35Z

    branch rebased

commit a1d3c85018268a7c8449ff1a45248c12dc53195a
Author: rahulforallp <[hidden email]>
Date:   2016-12-29T11:45:29Z

    float data type supported with spark-1.6 & spark-2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/480
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/374/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/480
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/375/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/480
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/379/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/480#discussion_r94580570
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/nondecimal/UnCompressNonDecimalByte.java ---
    @@ -85,12 +85,15 @@
       }
     
       @Override public CarbonReadDataHolder getValues(int decimal, Object maxValueObject) {
    --- End diff --
   
    This is not the way you supposed to do, please check how long data type is supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/480
 
    rename title from [Carbondata 390] to [CARBONDATA-390]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/480
 
    @rahulforallp  Thank you for working on it.
    But another PR https://github.com/apache/incubator-carbondata/pull/521 with simple changes are merged to master, so please close this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/480
 
    Ok, thanks for you support


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user rahulforallp closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/480


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---