[GitHub] incubator-carbondata pull request #481: [WIP]reuse test case for integration...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/480/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/490/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    Build Failed  with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/492/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/493/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/494/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/481#discussion_r95059829
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/test/TestQueryExecutorImplV1.scala ---
    @@ -0,0 +1,51 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.test
    +
    +import org.apache.spark.{SparkConf, SparkContext}
    +import org.apache.spark.sql.{CarbonContext, DataFrame, SQLContext}
    +
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +class TestQueryExecutorImplV1 extends TestQueryExecutorRegister {
    --- End diff --
   
    suggest change to SparkTestQueryExecutor and add comment description for this class
    accordingly, change TestQueryExecutorImplV2 to Spark2TestQueryExecutor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/481#discussion_r95059839
 
    --- Diff: integration/spark-common-test/pom.xml ---
    @@ -0,0 +1,232 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +    Licensed to the Apache Software Foundation (ASF) under one or more
    +    contributor license agreements.  See the NOTICE file distributed with
    +    this work for additional information regarding copyright ownership.
    +    The ASF licenses this file to You under the Apache License, Version 2.0
    +    (the "License"); you may not use this file except in compliance with
    +    the License.  You may obtain a copy of the License at
    +
    +       http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing, software
    +    distributed under the License is distributed on an "AS IS" BASIS,
    +    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +    See the License for the specific language governing permissions and
    +    limitations under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.carbondata</groupId>
    +    <artifactId>carbondata-parent</artifactId>
    +    <version>1.0.0-incubating-SNAPSHOT</version>
    +    <relativePath>../../pom.xml</relativePath>
    +  </parent>
    +
    +  <artifactId>carbondata-spark-common-test</artifactId>
    +  <name>Apache CarbonData :: Spark Common Test</name>
    +
    +  <properties>
    +    <dev.path>${basedir}/../../dev</dev.path>
    +  </properties>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.carbondata</groupId>
    +      <artifactId>carbondata-spark-common</artifactId>
    +      <version>${project.version}</version>
    +      <scope>test</scope>
    +      <exclusions>
    +        <exclusion>
    +          <groupId>org.apache.spark</groupId>
    +          <artifactId>spark-hive-thriftserver_2.10</artifactId>
    +        </exclusion>
    +      </exclusions>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.spark</groupId>
    +      <artifactId>spark-hive-thriftserver_${scala.binary.version}</artifactId>
    +      <scope>test</scope>
    +    </dependency>
    +    <dependency>
    +      <groupId>junit</groupId>
    +      <artifactId>junit</artifactId>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.scalatest</groupId>
    +      <artifactId>scalatest_${scala.binary.version}</artifactId>
    +      <version>2.2.1</version>
    +      <scope>test</scope>
    +    </dependency>
    +  </dependencies>
    +
    +  <build>
    +    <testSourceDirectory>src/test/scala</testSourceDirectory>
    +    <resources>
    +      <resource>
    +        <directory>src/resources</directory>
    +      </resource>
    +      <resource>
    +        <directory>.</directory>
    +        <includes>
    +          <include>CARBON_SPARK_INTERFACELogResource.properties</include>
    +        </includes>
    +      </resource>
    +    </resources>
    +    <plugins>
    +      <plugin>
    +        <groupId>org.scala-tools</groupId>
    +        <artifactId>maven-scala-plugin</artifactId>
    +        <version>2.15.2</version>
    +        <executions>
    +          <execution>
    +            <id>compile</id>
    +            <goals>
    +              <goal>compile</goal>
    +            </goals>
    +            <phase>compile</phase>
    +          </execution>
    +          <execution>
    +            <id>testCompile</id>
    +            <goals>
    +              <goal>testCompile</goal>
    +            </goals>
    +            <phase>test</phase>
    +          </execution>
    +          <execution>
    +            <phase>process-resources</phase>
    +            <goals>
    +              <goal>compile</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +      </plugin>
    +      <plugin>
    +        <artifactId>maven-compiler-plugin</artifactId>
    +        <configuration>
    +          <source>1.7</source>
    +          <target>1.7</target>
    +        </configuration>
    +      </plugin>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-surefire-plugin</artifactId>
    +        <version>2.18</version>
    +        <!-- Note config is repeated in scalatest config -->
    +        <configuration>
    +          <includes>
    +            <include>**/Test*.java</include>
    +            <include>**/*Test.java</include>
    +            <include>**/*TestCase.java</include>
    +            <include>**/*Suite.java</include>
    +          </includes>
    +          <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
    +          <argLine>-Xmx3g -XX:MaxPermSize=512m -XX:ReservedCodeCacheSize=512m</argLine>
    +          <systemProperties>
    +            <java.awt.headless>true</java.awt.headless>
    +          </systemProperties>
    +          <failIfNoTests>false</failIfNoTests>
    +        </configuration>
    +      </plugin>
    +      <plugin>
    +        <groupId>org.scalatest</groupId>
    +        <artifactId>scalatest-maven-plugin</artifactId>
    +        <version>1.0</version>
    +        <!-- Note config is repeated in surefire config -->
    +        <configuration>
    +          <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
    +          <junitxml>.</junitxml>
    +          <filereports>CarbonTestSuite.txt</filereports>
    +          <argLine>-ea -Xmx3g -XX:MaxPermSize=512m -XX:ReservedCodeCacheSize=512m
    +          </argLine>
    +          <stderr />
    +          <environmentVariables>
    +          </environmentVariables>
    +          <systemProperties>
    +            <java.awt.headless>true</java.awt.headless>
    +            <use.kettle>${use.kettle}</use.kettle>
    +          </systemProperties>
    +        </configuration>
    +        <executions>
    +          <execution>
    +            <id>test</id>
    +            <goals>
    +              <goal>test</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +      </plugin>
    +    </plugins>
    +  </build>
    +  <profiles>
    +    <profile>
    +      <id>spark-1.5</id>
    +      <activation>
    +        <activeByDefault>true</activeByDefault>
    +      </activation>
    +      <dependencies>
    +        <dependency>
    +          <groupId>org.apache.carbondata</groupId>
    +          <artifactId>carbondata-spark</artifactId>
    +          <version>${project.version}</version>
    +          <scope>test</scope>
    +          <exclusions>
    +            <exclusion>
    +              <groupId>org.apache.spark</groupId>
    +              <artifactId>spark-hive-thriftserver_2.10</artifactId>
    --- End diff --
   
    use scala.version instead of 2.10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/481#discussion_r95060180
 
    --- Diff: integration/spark-common-test/pom.xml ---
    @@ -0,0 +1,232 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +    Licensed to the Apache Software Foundation (ASF) under one or more
    +    contributor license agreements.  See the NOTICE file distributed with
    +    this work for additional information regarding copyright ownership.
    +    The ASF licenses this file to You under the Apache License, Version 2.0
    +    (the "License"); you may not use this file except in compliance with
    +    the License.  You may obtain a copy of the License at
    +
    +       http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing, software
    +    distributed under the License is distributed on an "AS IS" BASIS,
    +    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +    See the License for the specific language governing permissions and
    +    limitations under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.carbondata</groupId>
    +    <artifactId>carbondata-parent</artifactId>
    +    <version>1.0.0-incubating-SNAPSHOT</version>
    +    <relativePath>../../pom.xml</relativePath>
    +  </parent>
    +
    +  <artifactId>carbondata-spark-common-test</artifactId>
    +  <name>Apache CarbonData :: Spark Common Test</name>
    +
    +  <properties>
    +    <dev.path>${basedir}/../../dev</dev.path>
    +  </properties>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.carbondata</groupId>
    +      <artifactId>carbondata-spark-common</artifactId>
    +      <version>${project.version}</version>
    +      <scope>test</scope>
    +      <exclusions>
    +        <exclusion>
    +          <groupId>org.apache.spark</groupId>
    +          <artifactId>spark-hive-thriftserver_2.10</artifactId>
    +        </exclusion>
    +      </exclusions>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.spark</groupId>
    +      <artifactId>spark-hive-thriftserver_${scala.binary.version}</artifactId>
    +      <scope>test</scope>
    +    </dependency>
    +    <dependency>
    +      <groupId>junit</groupId>
    +      <artifactId>junit</artifactId>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.scalatest</groupId>
    +      <artifactId>scalatest_${scala.binary.version}</artifactId>
    +      <version>2.2.1</version>
    +      <scope>test</scope>
    +    </dependency>
    +  </dependencies>
    +
    +  <build>
    +    <testSourceDirectory>src/test/scala</testSourceDirectory>
    +    <resources>
    +      <resource>
    +        <directory>src/resources</directory>
    +      </resource>
    +      <resource>
    +        <directory>.</directory>
    +        <includes>
    +          <include>CARBON_SPARK_INTERFACELogResource.properties</include>
    +        </includes>
    +      </resource>
    +    </resources>
    +    <plugins>
    +      <plugin>
    +        <groupId>org.scala-tools</groupId>
    +        <artifactId>maven-scala-plugin</artifactId>
    +        <version>2.15.2</version>
    +        <executions>
    +          <execution>
    +            <id>compile</id>
    +            <goals>
    +              <goal>compile</goal>
    +            </goals>
    +            <phase>compile</phase>
    +          </execution>
    +          <execution>
    +            <id>testCompile</id>
    +            <goals>
    +              <goal>testCompile</goal>
    +            </goals>
    +            <phase>test</phase>
    +          </execution>
    +          <execution>
    +            <phase>process-resources</phase>
    +            <goals>
    +              <goal>compile</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +      </plugin>
    +      <plugin>
    +        <artifactId>maven-compiler-plugin</artifactId>
    +        <configuration>
    +          <source>1.7</source>
    +          <target>1.7</target>
    +        </configuration>
    +      </plugin>
    +      <plugin>
    +        <groupId>org.apache.maven.plugins</groupId>
    +        <artifactId>maven-surefire-plugin</artifactId>
    +        <version>2.18</version>
    +        <!-- Note config is repeated in scalatest config -->
    +        <configuration>
    +          <includes>
    +            <include>**/Test*.java</include>
    +            <include>**/*Test.java</include>
    +            <include>**/*TestCase.java</include>
    +            <include>**/*Suite.java</include>
    +          </includes>
    +          <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
    +          <argLine>-Xmx3g -XX:MaxPermSize=512m -XX:ReservedCodeCacheSize=512m</argLine>
    +          <systemProperties>
    +            <java.awt.headless>true</java.awt.headless>
    +          </systemProperties>
    +          <failIfNoTests>false</failIfNoTests>
    +        </configuration>
    +      </plugin>
    +      <plugin>
    +        <groupId>org.scalatest</groupId>
    +        <artifactId>scalatest-maven-plugin</artifactId>
    +        <version>1.0</version>
    +        <!-- Note config is repeated in surefire config -->
    +        <configuration>
    +          <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
    +          <junitxml>.</junitxml>
    +          <filereports>CarbonTestSuite.txt</filereports>
    +          <argLine>-ea -Xmx3g -XX:MaxPermSize=512m -XX:ReservedCodeCacheSize=512m
    +          </argLine>
    +          <stderr />
    +          <environmentVariables>
    +          </environmentVariables>
    +          <systemProperties>
    +            <java.awt.headless>true</java.awt.headless>
    +            <use.kettle>${use.kettle}</use.kettle>
    +          </systemProperties>
    +        </configuration>
    +        <executions>
    +          <execution>
    +            <id>test</id>
    +            <goals>
    +              <goal>test</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +      </plugin>
    +    </plugins>
    +  </build>
    +  <profiles>
    +    <profile>
    +      <id>spark-1.5</id>
    +      <activation>
    +        <activeByDefault>true</activeByDefault>
    +      </activation>
    +      <dependencies>
    +        <dependency>
    +          <groupId>org.apache.carbondata</groupId>
    +          <artifactId>carbondata-spark</artifactId>
    +          <version>${project.version}</version>
    +          <scope>test</scope>
    +          <exclusions>
    +            <exclusion>
    +              <groupId>org.apache.spark</groupId>
    +              <artifactId>spark-hive-thriftserver_2.10</artifactId>
    --- End diff --
   
    This exclusion will be fixed dependency issue of Intellij Idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/496/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/481#discussion_r95060705
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/test/TestQueryExecutorImplV1.scala ---
    @@ -0,0 +1,51 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.test
    +
    +import org.apache.spark.{SparkConf, SparkContext}
    +import org.apache.spark.sql.{CarbonContext, DataFrame, SQLContext}
    +
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +class TestQueryExecutorImplV1 extends TestQueryExecutorRegister {
    --- End diff --
   
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/481
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/481


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---