[GitHub] incubator-carbondata pull request #485: [CARBONDATA-580] Supporting Spark 2....

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/485

    [CARBONDATA-580] Supporting  Spark 2.1 in Carbon

    Supporting  Spark 2.1 in Carbon

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata spark2.1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #485
   
----
commit 025f23938839f80cde78a5fcd543a22fca5eda8e
Author: ravipesala <[hidden email]>
Date:   2016-12-30T17:19:58Z

    Supporting  Spark 2.1

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/485
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/388/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/485#discussion_r94279061
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/QueryTest.scala ---
    @@ -41,18 +41,11 @@ class QueryTest extends PlanTest {
     
     
       val rootPath = new File(this.getClass.getResource("/").getPath + "../../../..").getCanonicalPath
    -  val storeLocation = s"$rootPath/examples/spark2/target/store"
    -  val warehouse = s"$rootPath/examples/spark2/target/warehouse"
    -  val metastoredb = s"$rootPath/examples/spark2/target/metastore_db"
    +  val storeLocation = s"$rootPath/integration/spark2/target/store"
    +  val warehouse = s"$rootPath/integration/spark2/target/warehouse"
    +  val metastoredb = s"$rootPath/integration/spark2/target/metastore_db"
     
       val spark = {
    -    // clean data folder
    -    if (true) {
    --- End diff --
   
    Why remove "clean data folder" operations?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/485#discussion_r94290981
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/QueryTest.scala ---
    @@ -41,18 +41,11 @@ class QueryTest extends PlanTest {
     
     
       val rootPath = new File(this.getClass.getResource("/").getPath + "../../../..").getCanonicalPath
    -  val storeLocation = s"$rootPath/examples/spark2/target/store"
    -  val warehouse = s"$rootPath/examples/spark2/target/warehouse"
    -  val metastoredb = s"$rootPath/examples/spark2/target/metastore_db"
    +  val storeLocation = s"$rootPath/integration/spark2/target/store"
    +  val warehouse = s"$rootPath/integration/spark2/target/warehouse"
    +  val metastoredb = s"$rootPath/integration/spark2/target/metastore_db"
     
       val spark = {
    -    // clean data folder
    -    if (true) {
    --- End diff --
   
    It is not required now as drop table support is added in carbon spark 2 integration so drop table command can delete the store as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/485#discussion_r94292038
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/sql/common/util/QueryTest.scala ---
    @@ -41,18 +41,11 @@ class QueryTest extends PlanTest {
     
     
       val rootPath = new File(this.getClass.getResource("/").getPath + "../../../..").getCanonicalPath
    -  val storeLocation = s"$rootPath/examples/spark2/target/store"
    -  val warehouse = s"$rootPath/examples/spark2/target/warehouse"
    -  val metastoredb = s"$rootPath/examples/spark2/target/metastore_db"
    +  val storeLocation = s"$rootPath/integration/spark2/target/store"
    +  val warehouse = s"$rootPath/integration/spark2/target/warehouse"
    +  val metastoredb = s"$rootPath/integration/spark2/target/metastore_db"
     
       val spark = {
    -    // clean data folder
    -    if (true) {
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/485
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/485


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---