[GitHub] incubator-carbondata pull request #491: [CARBONDATA-583] Add replace functio...

[qiuchenjian-2]

GitHub user phalodi opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/491

    [CARBONDATA-583] Add replace function support for spark 1.6 and 2

    - Add replace function support with Spark 1.6 and 2.0
    - Manually test that replace function is working
    - Add replace function example for spark 1.6 and 2.0
    - Run all unit test cases

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phalodi/incubator-carbondata CARBONDATA-583

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #491
   
----
commit 71ca0726e767b47da50b2f259392665e5fcca0ec
Author: sandy <[hidden email]>
Date:   2017-01-03T13:18:07Z

    add replace function support for spark 1.6 and 2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/491
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user nareshpr commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/491
 
    Can you check regexp_replace spark function? This function replace all substrings of the specified string that matches the pattern


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user phalodi commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/491
 
    @nareshpr yes regexp_replace function already available in org.apache.spark.sql.functions package so if we want to use that in place of replace then we document it somewhere, Most of time user try replace directly as other database.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/491
 
    @phalodi  It is not good to add regular udf in carbon module unless carbondata wants it for some other features. What ever the functions available in spark we support the same and user can use the same functions. Carbondata does not require to document about Spark functions, user can refer the documentation of Spark for the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---