[GitHub] incubator-carbondata pull request #511: [CARBONDATA-584]added validation for...

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/511#discussion_r96108575
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -108,6 +110,10 @@ class CarbonSource extends CreatableRelationProvider
     
         val dbName: String = parameters.getOrElse("dbName", CarbonCommonConstants.DATABASE_DEFAULT_NAME)
         val tableName: String = parameters.getOrElse("tableName", "default_table")
    +    if(org.apache.commons.lang.StringUtils.isBlank(tableName) ||
    +       org.apache.commons.lang.StringUtils.isWhitespace(tableName)) {
    +      throw new MalformedCarbonCommandException("INVALID TABLE NAME")
    --- End diff --
   
    I think you misunderstood, I suggest to give "the specified table name is blank" in the exception message. Not suggesting to change the variable name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/511#discussion_r96108584
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -104,14 +106,17 @@ class CarbonSource extends CreatableRelationProvider
       }
     
       private def createTableIfNotExists(sparkSession: SparkSession, parameters: Map[String, String],
    -                                     dataSchema: StructType): String = {
    +      dataSchema: StructType): String = {
     
         val dbName: String = parameters.getOrElse("dbName", CarbonCommonConstants.DATABASE_DEFAULT_NAME)
    -    val tableName: String = parameters.getOrElse("tableName", "default_table")
    +    val emptyTableName: String = parameters.getOrElse("tableName", "default_table")
    +    if (StringUtils.isBlank(emptyTableName)) {
    +      throw new MalformedCarbonCommandException("INVALID TABLE NAME")
    --- End diff --
   
    I think there is misunderstanding, I suggest to give "the specified table name is blank" in the exception message. Not suggesting to change the variable name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/511#discussion_r96110103
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -104,14 +106,17 @@ class CarbonSource extends CreatableRelationProvider
       }
     
       private def createTableIfNotExists(sparkSession: SparkSession, parameters: Map[String, String],
    -                                     dataSchema: StructType): String = {
    +      dataSchema: StructType): String = {
     
         val dbName: String = parameters.getOrElse("dbName", CarbonCommonConstants.DATABASE_DEFAULT_NAME)
    -    val tableName: String = parameters.getOrElse("tableName", "default_table")
    +    val emptyTableName: String = parameters.getOrElse("tableName", "default_table")
    +    if (StringUtils.isBlank(emptyTableName)) {
    +      throw new MalformedCarbonCommandException("INVALID TABLE NAME")
    --- End diff --
   
    @jackylk oh get that now thats why i am asking you i m correcting it now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/511
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/599/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/511#discussion_r96110523
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -104,14 +106,17 @@ class CarbonSource extends CreatableRelationProvider
       }
     
       private def createTableIfNotExists(sparkSession: SparkSession, parameters: Map[String, String],
    -                                     dataSchema: StructType): String = {
    +      dataSchema: StructType): String = {
     
         val dbName: String = parameters.getOrElse("dbName", CarbonCommonConstants.DATABASE_DEFAULT_NAME)
    -    val tableName: String = parameters.getOrElse("tableName", "default_table")
    +    val emptyTableName: String = parameters.getOrElse("tableName", "default_table")
    +    if (StringUtils.isBlank(emptyTableName)) {
    +      throw new MalformedCarbonCommandException("INVALID TABLE NAME")
    --- End diff --
   
    @jackylk corrected it sry for mistake


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/511


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/511
 
    LGTM
    Thanks for working on this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---