[GitHub] incubator-carbondata pull request #526: [CARBONDATA-629] Issue with database...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #526: [CARBONDATA-629] Issue with database...

qiuchenjian-2
GitHub user manishgupta88 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/526

    [CARBONDATA-629] Issue with database name case sensitivity

    **Analysis:** When database name is provided in any DDL/DML command, the database name is interpreted and used in the same case as provided by the user. This leads to different behavior in windows and unix systems as windows is case sensitive and linux systems are case insensitive.
    Consider a case for create database. Lets say database name is "Carbon". While executing database name is provided as Carbon but while deleting or using or creating table the case is changed to "CARbOn". In these cases system will not behave correctly and if HDFS UI is checked the database Carbon will still exist even after dropping database as the case for database name was different in the 2 commands execution.
   
    **Fix:** Always convert the database name to lower case for any DDL/DML operation while parsing so that the behavior remains consistent.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manishgupta88/incubator-carbondata database_name_case_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #526
   
----
commit 8d77f3c046c5fadb4ad659c5ae9f69d3ca08f1ed
Author: manishgupta88 <[hidden email]>
Date:   2017-01-11T16:25:36Z

    Problem: Issue with database name case sensitivity
   
    Analysis: When database name is provided in any DDL/DML command, the database name is interpreted and used in the same case as provided by the user. This leads to different behavior in windows and unix systems as windows is case sensitive and linux systems are case insensitive.
    Consider a case for create database. Lets say database name is "Carbon". While executing database name is provided as Carbon but while deleting or using or creating table the case is changed to "CARbOn". In these cases system will not behave correctly and if HDFS UI is checked the database Carbon will still exist even after dropping database as the case for database name was different in the 2 commands execution.
   
    Fix: Always convert the database name to lower case for any DDL/DML operation while parsing so that the behavior remains consistent.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #526: [CARBONDATA-629] Issue with database name c...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/526
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/564/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #526: [CARBONDATA-629] Issue with database name c...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/526
 
    @manishgupta88 Can you add test case in common-test to module to cover both 1.6 and 2.1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #526: [CARBONDATA-629] Issue with database name c...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/526
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/566/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #526: [CARBONDATA-629] Issue with database name c...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/526
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/567/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #526: [CARBONDATA-629] Issue with database name c...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user manishgupta88 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/526
 
    @ravipesala ....Added test case. Please review and merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #526: [CARBONDATA-629] Issue with database name c...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/526
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #526: [CARBONDATA-629] Issue with database...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/526


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---