[GitHub] incubator-carbondata pull request #543: [CARBONDATA-619] give error if compa...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #543: [CARBONDATA-619] give error if compa...

qiuchenjian-2
GitHub user ravikiran23 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/543

    [CARBONDATA-619] give error if compaction type is not minor or major

    Scenario : in spark 2.1 API support for compaction is provided.
    in this API if the compaction type is anything other than the valid values(minor/major)  still the compaction is success taking the minor as type.
   
   
    Solution : if the user enters wrong value then the error message should be shown to the user.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravikiran23/incubator-carbondata CompactionTypeError

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #543
   
----
commit b3e2cf6af77c91d1847cc8166dc44c4016d134ce
Author: ravikiran <[hidden email]>
Date:   2017-01-17T08:39:25Z

    if the compaction type is not minor or major need to give error message to user.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #543: [CARBONDATA-619] give error if compaction t...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/543
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/637/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #543: [CARBONDATA-619] give error if compa...

qiuchenjian-2
In reply to this post by qiuchenjian-2
GitHub user ravikiran23 reopened a pull request:

    https://github.com/apache/incubator-carbondata/pull/543

    [CARBONDATA-619] give error if compaction type is not minor or major

    Scenario : in spark 2.1 API support for compaction is provided.
    in this API if the compaction type is anything other than the valid values(minor/major)  still the compaction is success taking the minor as type.
   
   
    Solution : if the user enters wrong value then the error message should be shown to the user.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravikiran23/incubator-carbondata CompactionTypeError

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #543
   
----
commit b3e2cf6af77c91d1847cc8166dc44c4016d134ce
Author: ravikiran <[hidden email]>
Date:   2017-01-17T08:39:25Z

    if the compaction type is not minor or major need to give error message to user.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #543: [CARBONDATA-619] give error if compaction t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravikiran23 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/543
 
    any of the admins please review and merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #543: [CARBONDATA-619] give error if compaction t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/543
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #543: [CARBONDATA-619] give error if compaction t...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/543
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #543: [CARBONDATA-619] give error if compa...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/543


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---