[GitHub] incubator-carbondata pull request #563: [CARBONDATA-670] Added MD Files

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #563: [CARBONDATA-670] Added MD Files

qiuchenjian-2
GitHub user PallaviSingh1992 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/563

    [CARBONDATA-670] Added MD Files

    Added following MD Files
    1. File Structure
    2. Data Types
   
    And Updated the Overview Section


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PallaviSingh1992/incubator-carbondata feature/NewMDFiles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/563.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #563
   
----
commit 3e6049b4973f64e7b07bb619d9b310d01707f362
Author: PallaviSingh1992 <[hidden email]>
Date:   2016-11-24T05:54:37Z

    added test cases for ThriftWriter

commit 9659694b3ab1ceff0ae9b914e2417598512255e6
Author: PallaviSingh1992 <[hidden email]>
Date:   2017-01-20T11:21:32Z

    Added MD Files for File Structure and Data Types

commit e02ba0a5a4783672d9deecf58ce75cefae12f4c1
Author: PallaviSingh1992 <[hidden email]>
Date:   2017-01-20T12:49:53Z

    removed unused files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #563: [CARBONDATA-670] Added MD Files

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/563
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/721/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #563: [CARBONDATA-670] Added MD Files

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/563#discussion_r97070802
 
    --- Diff: README.md ---
    @@ -40,6 +40,9 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com
     
     ## Online Documentation
     * [Quick Start](https://github.com/apache/incubator-carbondata/blob/master/docs/quick-start-guide.md)
    +* [Overview](https://github.com/apache/incubator-carbondata/blob/master/docs/overview-of-carbondata.md)
    --- End diff --
   
    remove overview-of-carbondata.md, duplicated info.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #563: [CARBONDATA-670] Added MD Files

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/563#discussion_r97071128
 
    --- Diff: docs/overview-of-carbondata.md ---
    @@ -0,0 +1,67 @@
    +<!--
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +      http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +-->
    +# Overview
    --- End diff --
   
    remove overview-of-carbondata.md file, don't need add non-technical document to github.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #563: [CARBONDATA-670] Added MD Files

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/563
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/734/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #563: [CARBONDATA-670] Added MD Files

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/563
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #563: [CARBONDATA-670] Added MD Files

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/563


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---