[GitHub] incubator-carbondata pull request #580: [CARBONDATA-685]added vaidation for ...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #580: [CARBONDATA-685]added vaidation for ...

qiuchenjian-2
GitHub user anubhav100 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/580

    [CARBONDATA-685]added vaidation for table name with spaces IN tableName option using carbon source

    when using carbon source i am able to create table with spaces
    logs====
    0: jdbc:hive2://localhost:10000> CREATE TABLE table (ID Int, date Timestamp, country String, name String, phonetype String, serialname String, salary Int) USING org.apache.spark.sql.CarbonSource OPTIONS("tableName"="t a b l e ");
    ---------+
    Result
    ---------+
    ---------+
    No rows select
    here table with empty spaces is created in hdfs
    it should not allow this
     
    with this pr this check will be validated


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-685

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #580
   
----
commit 4434579e8ea80f1c615cdf027be0811dd89e2b71
Author: anubhav100 <[hidden email]>
Date:   2017-01-29T12:31:44Z

    added vaidation for table name with spaces

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #580: [CARBONDATA-685]added vaidation for table n...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/580
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/780/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #580: [CARBONDATA-685]added vaidation for ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/580


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #580: [CARBONDATA-685]added vaidation for table n...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/580
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---