[GitHub] incubator-carbondata pull request #595: [CARBONDATA-700]corrected doc for dd...

[qiuchenjian-2]

GitHub user anubhav100 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/595

    [CARBONDATA-700]corrected doc for ddl operation using no_inverted_index

    example given in carbon docs ddl is wrong
   
    0: jdbc:hive2://localhost:10000> CREATE TABLE IF NOT EXISTS productSchema.productSalesTable ( productNumber Int, productName String, storeCity String, storeProvince String, productCategory String, productBatch String, saleQuantity Int, revenue Int) STORED BY 'carbondata' TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productCategory)', 'DICTIONARY_EXCLUDE'='productName', 'DICTIONARY_INCLUDE'='productNumber', 'NO_INVERTED_INDEX'='productBatch');
    Error: org.apache.carbondata.spark.exception.MalformedCarbonCommandException: Column group is not supported for no dictionary columns:productname (state=,code=0)
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-700

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #595
   
----
commit e6218624e5b189ae540fc4614337022a5fc16a92
Author: anubhav100 <[hidden email]>
Date:   2017-02-09T05:19:26Z

    corrected doc for ddl operation using no_inverted_index

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/595
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/880/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user Zhangshunyu commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/595
 
    it seems that it is about no dictionary, not about no inverted index, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/595
 
    @Zhangshunyu ya problem is with no dictionary but even after correcting it column groups are not contiguous this exception is thrown,so any ways this example will not work so I corrected the example in this pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/595
 
    please rebase it. @anubhav100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/595#discussion_r102417415
 
    --- Diff: docs/ddl-operation-on-carbondata.md ---
    @@ -115,8 +115,7 @@ TBLPROPERTIES ("COLUMN_GROUPS"="(column1,column3),
                                     saleQuantity Int,
                                     revenue Int)      
        STORED BY 'carbondata'
    -   TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productCategory)',
    -                  'DICTIONARY_EXCLUDE'='productName',
    +   TBLPROPERTIES ('COLUMN_GROUPS'='(productNumber,productName)',
                       'DICTIONARY_INCLUDE'='productNumber',
    --- End diff --
   
    Please add "DICTIONARY_EXCLUDE" with other column, which doesn't belong to COLUMN_GROUPS.
    Because this example is introducing both (DICTIONARY_EXCLUDE and DICTIONARY_INCLUDE)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/595#discussion_r102518052
 
    --- Diff: docs/ddl-operation-on-carbondata.md ---
    @@ -115,8 +115,7 @@ TBLPROPERTIES ("COLUMN_GROUPS"="(column1,column3),
                                     saleQuantity Int,
                                     revenue Int)      
        STORED BY 'carbondata'
    -   TBLPROPERTIES ('COLUMN_GROUPS'='(productName,productCategory)',
    -                  'DICTIONARY_EXCLUDE'='productName',
    +   TBLPROPERTIES ('COLUMN_GROUPS'='(productNumber,productName)',
                       'DICTIONARY_INCLUDE'='productNumber',
    --- End diff --
   
    @chenliang613 code is rebased and added add "DICTIONARY_EXCLUDE" with other column, which doesn't belong to COLUMN_GROUPS.can you review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/595
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/935/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/595
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/595


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---