[GitHub] incubator-carbondata pull request #609: [CARBONDATA-726] Added code for V3 f...

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102974988
 
    --- Diff: pom.xml ---
    @@ -93,6 +93,7 @@
     
       <modules>
         <module>common</module>
    + <module>format</module>
    --- End diff --
   
    don't add  <module>format</module> to default module list, it will compile fail if someone don't install thrift.  please only add <module>format</module> under profile "build-with-format". please refer to PR596:https://github.com/apache/incubator-carbondata/pull/596


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/959/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102981769
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -81,7 +81,7 @@
       /**
        * min blocklet size
        */
    -  public static final int BLOCKLET_SIZE_MIN_VAL = 50;
    +  public static final int BLOCKLET_SIZE_MIN_VAL = 2000;
    --- End diff --
   
    Number of rows in blocklet is exposed for V1 and V2 format so if user configure and any value we should validate whether is value is valid because of that min and max value is added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102981801
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -835,26 +834,23 @@
       /**
        * ZOOKEEPERLOCK TYPE
        */
    -  public static final String CARBON_LOCK_TYPE_ZOOKEEPER =
    -      "ZOOKEEPERLOCK";
    +  public static final String CARBON_LOCK_TYPE_ZOOKEEPER = "ZOOKEEPERLOCK";
     
       /**
        * LOCALLOCK TYPE
        */
    -  public static final String CARBON_LOCK_TYPE_LOCAL =
    -      "LOCALLOCK";
    +  public static final String CARBON_LOCK_TYPE_LOCAL = "LOCALLOCK";
     
       /**
        * HDFSLOCK TYPE
        */
    -  public static final String CARBON_LOCK_TYPE_HDFS =
    -      "HDFSLOCK";
    +  public static final String CARBON_LOCK_TYPE_HDFS = "HDFSLOCK";
     
       /**
        * Invalid filter member log string
        */
    -  public static final String FILTER_INVALID_MEMBER = " Invalid Record(s) are present "
    -                                                     + "while filter evaluation. ";
    +  public static final String FILTER_INVALID_MEMBER =
    +      " Invalid Record(s) are present " + "while filter evaluation. ";
    --- End diff --
   
    ok



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102982330
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java ---
    @@ -0,0 +1,232 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.datastore.columnar;
    +
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.util.ByteUtil;
    +
    +public class BlockIndexerStorageForShort implements IndexStorage<short[]> {
    +
    +  private boolean alreadySorted;
    +
    +  private short[] dataAfterComp;
    +
    +  private short[] indexMap;
    +
    +  private byte[][] keyBlock;
    +
    +  private short[] dataIndexMap;
    +
    +  private int totalSize;
    +
    +  public BlockIndexerStorageForShort(byte[][] keyBlock, boolean compressData,
    +      boolean isNoDictionary, boolean isSortRequired) {
    +    ColumnWithShortIndex[] columnWithIndexs = createColumnWithIndexArray(keyBlock, isNoDictionary);
    +    if (isSortRequired) {
    +      Arrays.sort(columnWithIndexs);
    +    }
    +    compressMyOwnWay(extractDataAndReturnIndexes(columnWithIndexs, keyBlock));
    +    if (compressData) {
    +      compressDataMyOwnWay(columnWithIndexs);
    +    }
    +  }
    +
    +  public BlockIndexerStorageForShort() {
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102982551
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -471,6 +472,33 @@ public static int nextGreaterValueToTarget(int currentIndex,
                 numberCompressor.unCompress(indexMap, 0, indexMap.length));
       }
     
    +  public static int[] getUnCompressColumnIndex(int totalLength, ByteBuffer buffer, int offset) {
    +    buffer.position(offset);
    +    int indexDataLength = buffer.getInt();
    +    int indexMapLength = totalLength - indexDataLength - CarbonCommonConstants.INT_SIZE_IN_BYTE;
    +    //    byte[] indexData = new byte[indexDataLength];
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102984611
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataFileFooterConverterV3.java ---
    @@ -0,0 +1,132 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.util;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.datastore.block.TableBlockInfo;
    +import org.apache.carbondata.core.metadata.ColumnarFormatVersion;
    +import org.apache.carbondata.core.metadata.blocklet.BlockletInfo;
    +import org.apache.carbondata.core.metadata.blocklet.DataFileFooter;
    +import org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex;
    +import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
    +import org.apache.carbondata.core.reader.CarbonFooterReader;
    +import org.apache.carbondata.format.FileFooter;
    +
    +public class DataFileFooterConverterV3 extends AbstractDataFileFooterConverter {
    +
    +  /**
    +   * Below method will be used to convert thrift file meta to wrapper file meta
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102984643
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java ---
    @@ -0,0 +1,256 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.datastore.chunk.reader.dimension.v3;
    +
    +import java.io.IOException;
    +import java.nio.ByteBuffer;
    +
    +import org.apache.carbondata.core.datastore.FileHolder;
    +import org.apache.carbondata.core.datastore.chunk.DimensionColumnDataChunk;
    +import org.apache.carbondata.core.datastore.chunk.impl.ColumnGroupDimensionDataChunk;
    +import org.apache.carbondata.core.datastore.chunk.impl.DimensionRawColumnChunk;
    +import org.apache.carbondata.core.datastore.chunk.impl.FixedLengthDimensionDataChunk;
    +import org.apache.carbondata.core.datastore.chunk.impl.VariableLengthDimensionDataChunk;
    +import org.apache.carbondata.core.datastore.chunk.reader.dimension.v2.CompressedDimensionChunkFileBasedReaderV2;
    +import org.apache.carbondata.core.datastore.columnar.UnBlockIndexer;
    +import org.apache.carbondata.core.metadata.blocklet.BlockletInfo;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +import org.apache.carbondata.format.DataChunk2;
    +import org.apache.carbondata.format.DataChunk3;
    +import org.apache.carbondata.format.Encoding;
    +
    +import org.apache.commons.lang.ArrayUtils;
    +
    +/**
    + * Dimension column V3 Reader class which will be used to read and uncompress
    + * V3 format data
    + * data format
    + * Data Format
    + * <Column1 Data ChunkV3><Column1<Page1><Page2><Page3><Page4>>
    + * <Column2 Data ChunkV3><Column2<Page1><Page2><Page3><Page4>>
    + * <Column3 Data ChunkV3><Column3<Page1><Page2><Page3><Page4>>
    + * <Column4 Data ChunkV3><Column4<Page1><Page2><Page3><Page4>>
    + */
    +public class CompressedDimensionChunkFileBasedReaderV3
    +    extends CompressedDimensionChunkFileBasedReaderV2 {
    +
    +  /**
    +   * end position of last dimension in carbon data file
    +   */
    +  private long lastDimensionOffsets;
    +
    +  public CompressedDimensionChunkFileBasedReaderV3(BlockletInfo blockletInfo,
    +      int[] eachColumnValueSize, String filePath) {
    +    super(blockletInfo, eachColumnValueSize, filePath);
    +    lastDimensionOffsets = blockletInfo.getDimensionOffset();
    +  }
    +
    +  /**
    +   * Below method will be used to read the dimension column data form carbon data file
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r102986005
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1151,6 +1139,68 @@
     
       public static final String USE_KETTLE_DEFAULT = "false";
     
    +  /**
    +   * number of page per blocklet column
    +   */
    +  public static final String NUMBER_OF_PAGE_IN_BLOCKLET_COLUMN =
    --- End diff --
   
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r103029623
 
    --- Diff: pom.xml ---
    @@ -93,6 +93,7 @@
     
       <modules>
         <module>common</module>
    + <module>format</module>
    --- End diff --
   
    This i have added to run all the testcases, I will remove after fixing all the failures


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/960/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/961/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/962/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/963/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/964/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/965/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r103073461
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -81,7 +81,7 @@
       /**
        * min blocklet size
        */
    -  public static final int BLOCKLET_SIZE_MIN_VAL = 50;
    +  public static final int BLOCKLET_SIZE_MIN_VAL = 2000;
    --- End diff --
   
    Because introduce page, you increase the min value of blocklet size from 50 to 2000?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/609#discussion_r103079634
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -83,7 +83,7 @@
       /**
    --- End diff --
   
    As introduce page into blocklet, if can increase  BLOCKLET_SIZE_DEFAULT_VAL?  it would reduce I/O cost further.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/966/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/609
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/967/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---