GitHub user jbonofre opened a pull request:
https://github.com/apache/incubator-carbondata/pull/613 [CARBONDATA-718] Add rat to check if all files contain ASF header and⦠⦠fix files with missing ASF header Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [X] Make sure the PR title is formatted like: `[CARBONDATA-<Jira issue #>] Description of pull request` - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [X] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). - [X] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - What manual testing you have done? - Any additional information to help reviewers in testing this change. - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbonofre/incubator-carbondata CARBONDATA-718 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/613.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #613 ---- commit 940c190d83819f6f5ec5cfad94ed605b63395f95 Author: Jean-Baptiste Onofré <[hidden email]> Date: 2017-02-27T09:58:37Z [CARBONDATA-718] Add rat to check if all files contain ASF header and fix files with missing ASF header ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Github user jbonofre commented on the issue:
https://github.com/apache/incubator-carbondata/pull/613 R: @chenliang613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/613#discussion_r103182873 --- Diff: pom.xml --- @@ -241,6 +241,32 @@ </pluginManagement> <plugins> <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> --- End diff -- In main pom.xml , already exists rat plugin , can you just update it: <plugin> <groupId>org.apache.rat</groupId> <artifactId>apache-rat-plugin</artifactId> <version>0.11</version> <executions> <execution> <phase>verify</phase> <goals> <goal>check</goal> </goals> </execution> </executions> <configuration> <reportFile>${project.build.directory}/${project.build.finalName}.rat</reportFile> <excludeSubProjects>false</excludeSubProjects> <useDefaultExcludes>true</useDefaultExcludes> <excludes> <exclude>**/*.iml</exclude> <exclude>**/*.csv</exclude> <exclude>**/*.dictionary</exclude> <exclude>**/*.ktr</exclude> <exclude>**/*.rat</exclude> <exclude>**/_SUCCESS</exclude> <exclude>**/non-csv</exclude> <exclude>**/.invisibilityfile</exclude> <exclude>**/noneCsvFormat.cs</exclude> <exclude>**/org.apache.spark.sql.sources.DataSourceRegister</exclude> <exclude>**/org.apache.spark.sql.test.TestQueryExecutorRegister</exclude> <exclude>**/derby.log</exclude> <exclude>**/meta.lock</exclude> <exclude>**/loadmetadata.metadata</exclude> <exclude>**/modifiedTime.mdt</exclude> <exclude>**/PULL_REQUEST_TEMPLATE.md</exclude> <exclude>**/dict.txt</exclude> <exclude>**/sample</exclude> <exclude>**/test.json</exclude> </excludes> </configuration> </plugin> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user jbonofre commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/613#discussion_r103185123 --- Diff: pom.xml --- @@ -241,6 +241,32 @@ </pluginManagement> <plugins> <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> --- End diff -- Good catch. I'm fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/613 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/972/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/613 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Free forum by Nabble | Edit this page |