[GitHub] incubator-carbondata pull request #628: [CARBONDATA-743] Remove redundant Ca...

[qiuchenjian-2]

GitHub user lionelcao opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/628

    [CARBONDATA-743] Remove redundant CarbonFilters file

    Remove redundant CarbonFilters file in spark2 and keep the one in spark common

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lionelcao/incubator-carbondata carbon743

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #628
   
----
commit 3ac7a8c25650b92cc7819ce10213b3cdfd8b8135
Author: lucao <[hidden email]>
Date:   2017-03-07T09:51:37Z

    [CARBONDATA-743] Remove redundant CarbonFilters file

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/628
 
    @lionelcao Thank you for working on this,
    But there are some differences in files from `CarbonFilters` of spark-common package and spark2 package. That is why I mentioned in jira to follow these steps,
    1.Delete the CarbonFilters scala file from spark-common package
    2. Move the CarbonFilters scala from spark2 package to spark-common package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user lionelcao commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/628
 
    Hi @ravipesala , I compared those two files before commit and I think the difference has no impact to the functionality. Any ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/628
 
    There is a difference in method `selectFilters` it takes one extra boolean in deleted file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/628
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/628


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---