[GitHub] incubator-carbondata pull request #658: [CARBONDATA-775]Updated Date DataTyp...

[qiuchenjian-2]

GitHub user PallaviSingh1992 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/658

    [CARBONDATA-775]Updated Date DataType in DataTypes supported by CarbonData

    Added the support for Date Data Type and re-structured the file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PallaviSingh1992/incubator-carbondata feature/UpdateDataTypeDoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #658
   
----
commit bbf4ecbe61a83b0e61c72f8801fb93c283b679d7
Author: PallaviSingh1992 <[hidden email]>
Date:   2017-03-15T11:27:20Z

    Updated Date DataType in DataTypes supported by CarbonData

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/658
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1158/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user PallaviSingh1992 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/658
 
    @chenliang613 please review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/658#discussion_r106403908
 
    --- Diff: docs/supported-data-types-in-carbondata.md ---
    @@ -22,17 +22,18 @@
     #### CarbonData supports the following data types:
     
       * Numeric Types
    -  * SMALLINT
    -  * INT/INTEGER
    -  * BIGINT
    -  * DOUBLE
    -  * DECIMAL
    +    * SMALLINT
    +    * INT/INTEGER
    +    * BIGINT
    +    * DOUBLE
    +    * DECIMAL
     
       * Date/Time Types
    -  * TIMESTAMP
    +    * TIMESTAMP
    +    * DATE
     
       * String Types
    -  * STRING
    +    * STRING
    --- End diff --
   
    I think CHAR can also be added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user PallaviSingh1992 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/658#discussion_r106408192
 
    --- Diff: docs/supported-data-types-in-carbondata.md ---
    @@ -22,17 +22,18 @@
     #### CarbonData supports the following data types:
     
       * Numeric Types
    -  * SMALLINT
    -  * INT/INTEGER
    -  * BIGINT
    -  * DOUBLE
    -  * DECIMAL
    +    * SMALLINT
    +    * INT/INTEGER
    +    * BIGINT
    +    * DOUBLE
    +    * DECIMAL
     
       * Date/Time Types
    -  * TIMESTAMP
    +    * TIMESTAMP
    +    * DATE
     
       * String Types
    -  * STRING
    +    * STRING
    --- End diff --
   
    @jackylk Thanks, resolved the review comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/658
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1187/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/658
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1203/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/658
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/658


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---