[GitHub] incubator-carbondata pull request #661: remove shutdown dictionary server

[qiuchenjian-2]

GitHub user lionelcao opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/661

    remove shutdown dictionary server

    remove shutdown dictionary server

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lionelcao/incubator-carbondata carbon761

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #661
   
----
commit f4cf54f844758441adecb3a40b16cc2868504a2d
Author: lucao <[hidden email]>
Date:   2017-03-16T02:53:08Z

    remove shutdown dictionary server

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/661
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1170/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/661#discussion_r106403716
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -599,11 +599,6 @@ case class LoadTable(
             // Once the data load is successful delete the unwanted partition files
             try {
     
    -          // shutdown dictionary server thread
    -          if (carbonLoadModel.getUseOnePass) {
    --- End diff --
   
    If this is not shut down, the next load operate will still try to start another dictionary server.
    Do you want to reuse this dictionary server in next load?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/661
 
    @lionelcao There is another PR https://github.com/apache/incubator-carbondata/pull/656 working on the same cause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---