[GitHub] incubator-carbondata pull request #688: [CARBONDATA-811] Refactor result col...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #688: [CARBONDATA-811] Refactor result col...

qiuchenjian-2
GitHub user thotasrinath opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/688

    [CARBONDATA-811] Refactor result collector class

    **Problem**: For each batch result collector class is filling all the class level variable this may hit the performance
    **Solution**: fill it in constructor, so only once it will be initialize.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thotasrinath/incubator-carbondata RefactorResultCollectorClass

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #688
   
----
commit 093609eb361172d882f994ab2b175aa44d98be31
Author: Srinath Thota <[hidden email]>
Date:   2017-03-23T11:47:57Z

    [CARBONDATA-801] Examples syntax fix

commit 979e0a0ffb9baec45bcc5b5f69caf9ef071ec328
Author: thotasrinath <[hidden email]>
Date:   2017-03-23T12:27:47Z

    Refactor Dictionary based Result Collector Class

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #688: [CARBONDATA-811] Refactor result collector ...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/688
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #688: [CARBONDATA-811] Refactor result collector ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/688
 
    add to whitelist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #688: [CARBONDATA-811] Refactor result collector ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/688
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1305/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #688: [CARBONDATA-811] Refactor result col...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user thotasrinath closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/688


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #688: [CARBONDATA-811] Refactor result collector ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/688
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1307/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---