[GitHub] incubator-carbondata pull request #690: [CARBONDATA-811] Refactor dictionary...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #690: [CARBONDATA-811] Refactor dictionary...

qiuchenjian-2
GitHub user thotasrinath opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/690

    [CARBONDATA-811] Refactor dictionary based result collector class.

    Initialization of variables is moved to constructor. So that initialization is done only once on object creation instead of running a business logic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thotasrinath/incubator-carbondata ResultCollectorClassOptimization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/690.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #690
   
----
commit 542fcb921ac32eeb8b26e484dbd60b9b5fb16e8c
Author: thotasrinath <[hidden email]>
Date:   2017-03-23T13:44:13Z

    Refactor dictionary based result collector class.
    Initialization of variables is moved to constructor. So that initialization is done only once on object creation instead of running a business logic.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #690: [CARBONDATA-811] Refactor dictionary based ...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/690
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1308/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata issue #690: [CARBONDATA-811] Refactor dictionary based ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/690
 
    LGTM. Testcases are failing not because of this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #690: [CARBONDATA-811] Refactor dictionary...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/690


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---