[GitHub] incubator-carbondata pull request #724: [CARBONDATA-847] Fixed NullPointerEx...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/724

    [CARBONDATA-847] Fixed NullPointerException for DictionaryBasedVectorResultCollector during alter table

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-847

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #724
   
----
commit 6936e023fdab79a4d6ebd43f1457844261ac30fc
Author: kunal642 <[hidden email]>
Date:   2017-04-03T17:24:18Z

    fixed null pointer exception for DictionaryBasedVectorResultCollector during alter table

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/724
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1407/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/724
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1409/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/724
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1410/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/724#discussion_r109851124
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java ---
    @@ -51,8 +51,8 @@
     
       public DictionaryBasedVectorResultCollector(BlockExecutionInfo blockExecutionInfos) {
         super(blockExecutionInfos);
    -    queryDimensions = tableBlockExecutionInfos.getQueryDimensions();
    -    queryMeasures = tableBlockExecutionInfos.getQueryMeasures();
    +    queryDimensions = tableBlockExecutionInfos.getActualQueryDimensions();
    --- End diff --
   
    Why getting `actualQueryDimensions` instead of `queryDimensions` in `DictionaryBasedVectorResultCollector`? But we get only `queryDimensions` in `DictionaryBasedResultCollector`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/724#discussion_r109861944
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java ---
    @@ -51,8 +51,8 @@
     
       public DictionaryBasedVectorResultCollector(BlockExecutionInfo blockExecutionInfos) {
         super(blockExecutionInfos);
    -    queryDimensions = tableBlockExecutionInfos.getQueryDimensions();
    -    queryMeasures = tableBlockExecutionInfos.getQueryMeasures();
    +    queryDimensions = tableBlockExecutionInfos.getActualQueryDimensions();
    --- End diff --
   
    getQueryDimensions or getQueryMeasures does not contain the newly added columns so when we try to get the vector from allColumnInfo which has the size [measures + dimensions] we would get a ArrayIndexOutOfBoundException because it will not have the space for the new column.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/724
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1438/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/724#discussion_r110081351
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java ---
    @@ -51,8 +51,8 @@
     
       public DictionaryBasedVectorResultCollector(BlockExecutionInfo blockExecutionInfos) {
         super(blockExecutionInfos);
    -    queryDimensions = tableBlockExecutionInfos.getQueryDimensions();
    -    queryMeasures = tableBlockExecutionInfos.getQueryMeasures();
    +    queryDimensions = tableBlockExecutionInfos.getActualQueryDimensions();
    --- End diff --
   
    I did not get, if any restructuring is required then it supposed to go to `RestructureBasedVectorResultCollector` class right. why it comes here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/724
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1484/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/724
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/724


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---