[GitHub] incubator-carbondata pull request #810: [CARBONDATA-935] Define PartitionInf...

[qiuchenjian-2]

GitHub user lionelcao opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/810

    [CARBONDATA-935] Define PartitionInfo Model

    modify schema.thrift
    modify TableSchema.java
    add new partition related classes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lionelcao/incubator-carbondata carbon_910_1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #810
   
----
commit 41a720bbd43f33f1b7a6b0f14143c7805fbf6127
Author: lucao <[hidden email]>
Date:   2017-04-18T06:52:18Z

    [CARBONDATA-935] Define PartitionInfo model

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/810
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1678/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/810
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1680/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/810
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1681/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/810#discussion_r112100462
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1185,6 +1185,8 @@
     
       public static final String CARBON_BAD_RECORDS_ACTION_DEFAULT = "FORCE";
     
    +  public static final String CARBON_PARTITION_NAME_PREFIX = "Part_";
    --- End diff --
   
    Please add it in internal class, it should not be exposed to user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102312
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,27 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    +    1: required i32 partition_id;
    +    2: required list<ColumnSchema> partition_columns;
    +    3: required list<Partitioning> partitioning_list;
    --- End diff --
   
    no need Partitioning, Because PartitionInfo already included Partitioning


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102773
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,27 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    +    1: required i32 partition_id;
    +    2: required list<ColumnSchema> partition_columns;
    --- End diff --
   
    no need column list, Because PartitionInfo already included column list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102257
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,27 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    +    1: required i32 partition_id;
    +    2: required list<ColumnSchema> partition_columns;
    +    3: required list<Partitioning> partitioning_list;
    +    4: required list<string> boundary_value_list;
    +    5: optional string partition_name;
    +}
    +
    +/**
    + * Partition information of table
    + */
    +struct PartitionInfo{
    +    1: required list<SinglePartition> partition_list;
    +    2: required list<ColumnSchema> partition_columns;
    +    3: required list<Partitioning> partitioning_list;
    --- End diff --
   
    better to use Partitioning instead of list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102353
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,27 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    +    1: required i32 partition_id;
    --- End diff --
   
    better to be optional


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102662
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,27 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    +    1: required i32 partition_id;
    +    2: required list<ColumnSchema> partition_columns;
    +    3: required list<Partitioning> partitioning_list;
    +    4: required list<string> boundary_value_list;
    +    5: optional string partition_name;
    +}
    +
    +/**
    + * Partition information of table
    + */
    +struct PartitionInfo{
    +    1: required list<SinglePartition> partition_list;
    +    2: required list<ColumnSchema> partition_columns;
    +    3: required list<Partitioning> partitioning_list;
    +    4: required i32 number_of_partitions;
    --- End diff --
   
    this is optional


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/810
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1690/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/810
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user lionelcao closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/810


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---