[GitHub] incubator-carbondata pull request #830: [CARBONDATA-969] Don't persist rdd b...

[qiuchenjian-2]

GitHub user watermen opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/830

    [CARBONDATA-969] Don't persist rdd because it is only use once

    In GlobalDictionaryUtil.readAllDictionaryFiles, don't persist rdd because it is only use once.
   
    @foryou2030 Can you check it because persist is added by you?
    cc @QiangCai

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/watermen/incubator-carbondata CARBONDATA-969

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #830
   
----
commit 490fcafe3565469f43c1bcd8a8dbbf454718a317
Author: Yadong Qi <[hidden email]>
Date:   2017-04-21T02:05:53Z

    Don't persist rdd if it is only use once.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/830
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1724/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user foryou2030 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/830#discussion_r112597852
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala ---
    @@ -630,7 +630,7 @@ object GlobalDictionaryUtil {
         try {
           // read local dictionary file, and spilt (columnIndex, columnValue)
           val basicRdd = sqlContext.sparkContext.textFile(allDictionaryPath)
    -        .map(x => parseRecord(x, accumulator, csvFileColumns)).persist()
    +        .map(x => parseRecord(x, accumulator, csvFileColumns))
    --- End diff --
   
    yes, it is no need. thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/830
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/830


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---