[GitHub] incubator-carbondata pull request #843: Range Filter Evaluation Rectificatio...

[qiuchenjian-2]

GitHub user sounakr opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/843

    Range Filter Evaluation Rectification

    Problem : Range Expression filter evaluation is unable to retreive correct output.
   
    Analysis : Range Filter Expression evaluation is unable to filter out correct values when the filter values are not present in the data. The Binary Search method always returns a value greater than the compared value being passed to it and the value doesn't match in the list.
    For Less Than and Greater than condition the non macthing return value should be adjusted accordingly.
   
    Fix : Fix the value which is being returned from the binary search method whenever the compared values doesnt match any data in the list.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sounakr/incubator-carbondata range_modify

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/843.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #843
   
----
commit 96f64d69ca661a35a9661b905badb600faeae027
Author: sounakr <[hidden email]>
Date:   2017-04-24T08:56:45Z

    Range Filter Check Rectification

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/843
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1773/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/843#discussion_r112919687
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java ---
    @@ -431,14 +426,9 @@ private BitSet setFilterdIndexToBitSetWithColumnIndex(
             if (start == numerOfRows) {
               start = start - 1;
             }
    -        // Method will compare the tentative index value after binary search, this tentative
    -        // index needs to be compared by the filter member if its >= filter then from that
    -        // index the bitset will be considered for filtering process.
    -        if ((lessThanExp == true) && (ByteUtil.compare(filterValues[1],
    -            dimensionColumnDataChunk.getChunkData(dimensionColumnDataChunk.getInvertedIndex(start)))
    -            < 0)) {
    -          start = start - 1;
    -        } else if ((lessThanEqualExp == true) && (ByteUtil.compare(filterValues[1],
    +        // In case the start is less than 0, then positive value of start is pointing to the next
    +        // value of the searched key. So move to the previous one.
    +        if ((ByteUtil.compare(filterValues[1],
    --- End diff --
   
    Please don't use this compare method, it does not compare based on length


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/843
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1774/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/843
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1776/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/843
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/843


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---