[GitHub] incubator-carbondata pull request #850: [CARBONDATA-986] Add alter table exa...

[qiuchenjian-2]

GitHub user chenerlu opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/850

    [CARBONDATA-986] Add alter table example

    Description: Just add alter table example for testing alter table grammar

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenerlu/incubator-carbondata AddExamples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/850.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #850
   
----
commit 5e36129169489d51632eab860dc24a800bae273b
Author: erlu <[hidden email]>
Date:   2017-04-26T02:54:19Z

    add alter table example

commit ccaae369a65bfde44de6622be446ddc9864187e9
Author: erlu <[hidden email]>
Date:   2017-04-26T03:18:54Z

    add alter table example

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/850
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1797/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/850
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1803/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/850#discussion_r113427472
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlterTableExample.scala ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.spark.sql.CarbonSession._
    +import org.apache.spark.sql.SparkSession
    +
    +/**
    +  * Created by erlu on 2017/4/25.
    --- End diff --
   
    the comment format is incorrect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/850#discussion_r113429361
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlterTableExample.scala ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.spark.sql.CarbonSession._
    +import org.apache.spark.sql.SparkSession
    +
    +/**
    +  * Created by erlu on 2017/4/25.
    +  */
    +object AlterTableExample {
    +
    +  def main(args: Array[String]): Unit = {
    +
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +
    +    val storeLocation = s"$rootPath/examples/spark2/target/store"
    +    val warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    val metastoredb = s"$rootPath/examples/spark2/target/metastore_db"
    +
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/MM/dd")
    +
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("AlterTableExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +
    +    spark.sparkContext.setLogLevel("INFO")
    +
    +    spark.sql("DROP TABLE IF EXISTS carbon_table")
    +    spark.sql("DROP TABLE IF EXISTS new_carbon_table")
    +
    +    spark.sql(
    +      s"""
    +         | CREATE TABLE carbon_table(
    +         |    shortField short,
    +         |    intField int,
    +         |    bigintField long,
    +         |    doubleField double,
    +         |    stringField string,
    +         |    timestampField timestamp,
    +         |    decimalField decimal(18,2),
    +         |    dateField date,
    +         |    charField char(5),
    +         |    floatField float,
    +         |    complexData array<string>
    +         | )
    +         | STORED BY 'carbondata'
    +         | TBLPROPERTIES('DICTIONARY_INCLUDE'='dateField, charField')
    +       """.stripMargin)
    +
    +    // Alter table change data type
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +    spark.sql("ALTER TABLE carbon_table CHANGE intField intField bigint").show()
    --- End diff --
   
    why here put two "intField"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/850#discussion_r113429928
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlterTableExample.scala ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.spark.sql.CarbonSession._
    +import org.apache.spark.sql.SparkSession
    +
    +/**
    +  * Created by erlu on 2017/4/25.
    +  */
    +object AlterTableExample {
    +
    +  def main(args: Array[String]): Unit = {
    +
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +
    +    val storeLocation = s"$rootPath/examples/spark2/target/store"
    +    val warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    val metastoredb = s"$rootPath/examples/spark2/target/metastore_db"
    +
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/MM/dd")
    +
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("AlterTableExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +
    +    spark.sparkContext.setLogLevel("INFO")
    +
    +    spark.sql("DROP TABLE IF EXISTS carbon_table")
    +    spark.sql("DROP TABLE IF EXISTS new_carbon_table")
    +
    +    spark.sql(
    +      s"""
    +         | CREATE TABLE carbon_table(
    +         |    shortField short,
    +         |    intField int,
    +         |    bigintField long,
    +         |    doubleField double,
    +         |    stringField string,
    +         |    timestampField timestamp,
    +         |    decimalField decimal(18,2),
    +         |    dateField date,
    +         |    charField char(5),
    +         |    floatField float,
    +         |    complexData array<string>
    +         | )
    +         | STORED BY 'carbondata'
    +         | TBLPROPERTIES('DICTIONARY_INCLUDE'='dateField, charField')
    +       """.stripMargin)
    +
    +    // Alter table change data type
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +    spark.sql("ALTER TABLE carbon_table CHANGE intField intField bigint").show()
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +
    +    // Alter table add columns
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +    spark.sql("ALTER TABLE carbon_table ADD COLUMNS (newField String)" +
    +      " TBLPROPERTIES ('DEFAULT.VALUE.newField'='def')").show()
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +
    +    // Alter table drop columns
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    --- End diff --
   
    this row is not required. same as row83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/850#discussion_r113430144
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlterTableExample.scala ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.spark.sql.CarbonSession._
    +import org.apache.spark.sql.SparkSession
    +
    +/**
    +  * Created by erlu on 2017/4/25.
    +  */
    +object AlterTableExample {
    +
    +  def main(args: Array[String]): Unit = {
    +
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +
    +    val storeLocation = s"$rootPath/examples/spark2/target/store"
    +    val warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    val metastoredb = s"$rootPath/examples/spark2/target/metastore_db"
    +
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/MM/dd")
    +
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("AlterTableExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +
    +    spark.sparkContext.setLogLevel("INFO")
    +
    +    spark.sql("DROP TABLE IF EXISTS carbon_table")
    +    spark.sql("DROP TABLE IF EXISTS new_carbon_table")
    +
    +    spark.sql(
    +      s"""
    +         | CREATE TABLE carbon_table(
    +         |    shortField short,
    +         |    intField int,
    +         |    bigintField long,
    +         |    doubleField double,
    +         |    stringField string,
    +         |    timestampField timestamp,
    +         |    decimalField decimal(18,2),
    +         |    dateField date,
    +         |    charField char(5),
    +         |    floatField float,
    +         |    complexData array<string>
    +         | )
    +         | STORED BY 'carbondata'
    +         | TBLPROPERTIES('DICTIONARY_INCLUDE'='dateField, charField')
    +       """.stripMargin)
    +
    +    // Alter table change data type
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +    spark.sql("ALTER TABLE carbon_table CHANGE intField intField bigint").show()
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +
    +    // Alter table add columns
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +    spark.sql("ALTER TABLE carbon_table ADD COLUMNS (newField String)" +
    +      " TBLPROPERTIES ('DEFAULT.VALUE.newField'='def')").show()
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +
    +    // Alter table drop columns
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +    spark.sql("ALTER TABLE carbon_table DROP COLUMNS (newField)").show()
    --- End diff --
   
    can you change the drop column to other column, not just added column.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/850#discussion_r113447813
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlterTableExample.scala ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.spark.sql.CarbonSession._
    +import org.apache.spark.sql.SparkSession
    +
    +/**
    +  * Created by erlu on 2017/4/25.
    +  */
    +object AlterTableExample {
    +
    +  def main(args: Array[String]): Unit = {
    +
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +
    +    val storeLocation = s"$rootPath/examples/spark2/target/store"
    +    val warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    val metastoredb = s"$rootPath/examples/spark2/target/metastore_db"
    +
    +    CarbonProperties.getInstance().addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/MM/dd")
    +
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("AlterTableExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +
    +    spark.sparkContext.setLogLevel("INFO")
    +
    +    spark.sql("DROP TABLE IF EXISTS carbon_table")
    +    spark.sql("DROP TABLE IF EXISTS new_carbon_table")
    +
    +    spark.sql(
    +      s"""
    +         | CREATE TABLE carbon_table(
    +         |    shortField short,
    +         |    intField int,
    +         |    bigintField long,
    +         |    doubleField double,
    +         |    stringField string,
    +         |    timestampField timestamp,
    +         |    decimalField decimal(18,2),
    +         |    dateField date,
    +         |    charField char(5),
    +         |    floatField float,
    +         |    complexData array<string>
    +         | )
    +         | STORED BY 'carbondata'
    +         | TBLPROPERTIES('DICTIONARY_INCLUDE'='dateField, charField')
    +       """.stripMargin)
    +
    +    // Alter table change data type
    +    spark.sql("DESCRIBE FORMATTED carbon_table").show()
    +    spark.sql("ALTER TABLE carbon_table CHANGE intField intField bigint").show()
    --- End diff --
   
    This is Alter table change data type grammar


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/850
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1809/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/850
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1810/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/850
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1812/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/850
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/850


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/850
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1813/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---