[GitHub] incubator-carbondata pull request #876: [CARBONDATA-935] Define PartitionInf...

[qiuchenjian-2]

GitHub user lionelcao opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/876

    [CARBONDATA-935] Define PartitionInfo model

    Define PartitionInfo model

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lionelcao/incubator-carbondata 12-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/876.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #876
   
----
commit c4c05f8a55c25e5f0f84b48f49682c6b82787341
Author: lucao <[hidden email]>
Date:   2017-04-18T06:52:18Z

    [CARBONDATA-935] Define PartitionInfo model
   
    fix javastyle error
   
    modify partitioninfo and singlePartition
   
    modify schema.thrift to add partitioningList
   
    modify definition

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1866/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114467968
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/partition/SinglePartition.java ---
    @@ -0,0 +1,92 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.metadata.schema.partition;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +public class SinglePartition implements Serializable {
    +
    +  /**
    +   * partition id
    +   */
    +  private int partition_id;
    --- End diff --
   
    we should use the same coding convention like other code.
    rename to `partitionId`
    please modify all variable in this class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114468043
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/partition/SinglePartition.java ---
    @@ -0,0 +1,92 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.metadata.schema.partition;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +public class SinglePartition implements Serializable {
    --- End diff --
   
    Name it `Partition` is better, you can add comment to describe it is the class for one partition


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114468076
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/partition/SinglePartition.java ---
    @@ -0,0 +1,92 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.metadata.schema.partition;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +public class SinglePartition implements Serializable {
    +
    +  /**
    +   * partition id
    +   */
    +  private int partition_id;
    +
    +  /**
    +   * partition name
    +   */
    +  private String partition_name;
    --- End diff --
   
    why name is required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114468110
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/partition/SinglePartition.java ---
    @@ -0,0 +1,92 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.metadata.schema.partition;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +public class SinglePartition implements Serializable {
    +
    +  /**
    +   * partition id
    --- End diff --
   
    please add meaningful comment, or remove it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114468427
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,25 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    --- End diff --
   
    rename to `Partition`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114468468
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,25 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    +    1: optional i32 partition_id;
    --- End diff --
   
    Isn't `partitionId` mandatory?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114468530
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,25 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct SinglePartition{
    +    1: optional i32 partition_id;
    +    2: required list<string> boundary_value_list;
    --- End diff --
   
    Isn't this optional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1867/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1868/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114481333
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,24 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct Partition{
    +    1: optional i32 partition_id;
    +    2: required list<string> boundary_value_list;
    +}
    +
    +/**
    + * Partition information of table
    + */
    +struct PartitionInfo{
    --- End diff --
   
    To make this metadata more clear, can we do like this:
    `struct PartitionInfo {
    1: required PartitionType type;
    2: optional RangePartitionInfo rangePartitionInfo;
    3: optional ListPartitionInfo listPartitionInfo;
    ...
    }
    `
    So that you can access each partition info based on the first member (type)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114481601
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/partition/Partition.java ---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.metadata.schema.partition;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +/**
    + * One single partition
    + */
    +public class Partition implements Serializable {
    +
    +  private int partitionId;
    +
    +  /**
    +   * boundary value list for multi-level partition
    +   */
    +  private List<String> boundaryValueList;
    --- End diff --
   
    I think this is not required for all partition type, for example, hash partition does not require this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1870/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114495295
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,24 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct Partition{
    +    1: optional i32 partition_id;
    +    2: required list<string> boundary_value_list;
    +}
    +
    +/**
    + * Partition information of table
    + */
    +struct PartitionInfo{
    --- End diff --
   
    How about?
    struct PartitionInfo {
    1: required PartitionType type;
    2: required list<ColumnSchema> partition_columns;
    3: optional RangeInfo rangeInfo;
    4: optional ListInfo listInfo;
    }


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1881/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1882/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114691292
 
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,25 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct Partition{
    --- End diff --
   
    please remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1883/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/876
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---