[GitHub] kevinjmh commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MVAnalyzerRule for Command

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] kevinjmh commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MVAnalyzerRule for Command

GitBox
kevinjmh commented on a change in pull request #3124: [CARBONDATA-3290] No need to apply MVAnalyzerRule for Command
URL: https://github.com/apache/carbondata/pull/3124#discussion_r255922743
 
 

 ##########
 File path: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonAnalyzer.scala
 ##########
 @@ -42,10 +42,10 @@ class CarbonAnalyzer(catalog: SessionCatalog,
     var logicalPlan = analyzer.execute(plan)
     logicalPlan = CarbonPreAggregateDataLoadingRules(sparkSession).apply(logicalPlan)
     logicalPlan = CarbonPreAggregateQueryRules(sparkSession).apply(logicalPlan)
-    if (mvPlan != null) {
+    if (mvPlan != null && !logicalPlan.isInstanceOf[Command]) {
 
 Review comment:
   both CarbonPreAggregateDataLoadingRules and CarbonPreAggregateQueryRules are no need for Command. I will fix it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services