[GitHub] kumarvishal09 commented on a change in pull request #3068: [HOTFIX] Fixed NPE during query with Local Dictionary

[GitBox]

kumarvishal09 commented on a change in pull request #3068: [HOTFIX] Fixed NPE during query with Local Dictionary
URL: https://github.com/apache/carbondata/pull/3068#discussion_r248963600
 
 

 ##########
 File path: integration/spark-datasource/src/main/spark2.1andspark2.2/org/apache/spark/sql/CarbonVectorProxy.java
 ##########
 @@ -311,6 +311,7 @@ public void setDictionary(CarbonDictionary dictionary) {
         vector.setDictionary(dictionaryWrapper);
         this.dictionary = dictionaryWrapper;
       } else {
+        this.dictionary = null;
 
 Review comment:
   In 2.3 proper interface are exposed from spark and same has been implemented, so its not required

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services