[GitHub] kumarvishal09 commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] kumarvishal09 commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue

GitBox
kumarvishal09 commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue
URL: https://github.com/apache/carbondata/pull/3096#discussion_r250102449
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortParameters.java
 ##########
 @@ -442,6 +446,8 @@ public static SortParameters createSortParameters(CarbonDataLoadConfiguration co
     parameters.setTempFileLocation(sortTempDirs);
     LOGGER.info("temp file location: " + StringUtils.join(parameters.getTempFileLocation(), ","));
 
+    parameters.setIsRangeSort(CarbonDataProcessorUtil.getSortScope(configuration)
+        == SortScopeOptions.SortScope.GLOBAL_SORT);
 
 Review comment:
   Okay...i will update

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services