[GitHub] kumarvishal09 commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue

[GitBox]

kumarvishal09 commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue
URL: https://github.com/apache/carbondata/pull/3096#discussion_r250219551
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/memory/IntPointerBuffer.java
 ##########
 @@ -75,17 +75,17 @@ public int get(int rowId) {
   }
 
   public void loadToUnsafe() {
-    try {
-      pointerMemoryBlock =
-          UnsafeSortMemoryManager.allocateMemoryWithRetry(this.taskId, pointerBlock.length * 4);
+    pointerMemoryBlock =
+        UnsafeSortMemoryManager.INSTANCE.allocateMemory(this.taskId, pointerBlock.length * 4);
+    // pointerMemoryBlock it means sort storage memory manager does not have space to loaf pointer
+    // buffer in that case use pointerBlock
+    if (null != pointerMemoryBlock) {
 
 Review comment:
   adding log for not getting sort storage memory won't be a good idea as it will add overhead in case of huge data

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services