kunal642 commented on a change in pull request #3105: [CARBONDATA-3275][TEST] Fix 4 errors in CI after PR 3094 merged
URL:
https://github.com/apache/carbondata/pull/3105#discussion_r251191577
##########
File path: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala
##########
@@ -775,13 +775,12 @@ test("test alter command for boolean data type with correct default measure valu
.addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, timestampFormat)
}
-
test("Alter Table Change Sort Scope 1") {
sql("DROP TABLE IF EXISTS t1")
sql(s"CREATE TABLE t1(age int, name string) STORED BY 'carbondata' TBLPROPERTIES" +
s"('sort_columns'='age', 'sort_scope'='local_sort')")
sql("ALTER TABLE t1 SET TBLPROPERTIES('sort_scope'='batch_sort')")
- assert(sortScopeInDescFormatted("t1").equalsIgnoreCase("BATCH_SORT"))
+ assert(sortScopeInDescFormatted("t1").equalsIgnoreCase("Some(BATCH_SORT)"))
Review comment:
instead of changing the test case can you change describe formatted command to show only the scope and not the Option. Currently toString is called on Option therefore it is showing Some("batch_sort")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
