[GitHub] manishgupta88 commented on a change in pull request #3106: [CARBONDATA-3276] Compacting table that do not exist should throw NoSuchTableException instead of MalformedCarbonCommandException

[GitBox]

manishgupta88 commented on a change in pull request #3106: [CARBONDATA-3276] Compacting table that do not exist should throw NoSuchTableException instead of MalformedCarbonCommandException
URL: https://github.com/apache/carbondata/pull/3106#discussion_r257894951
 
 

 ##########
 File path: common/src/main/java/org/apache/carbondata/common/exceptions/sql/NoSuchCarbonTableException.java
 ##########
 @@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.common.exceptions.sql;
+
+import org.apache.carbondata.common.annotations.InterfaceAudience;
+import org.apache.carbondata.common.annotations.InterfaceStability;
+
[e-mail]
[e-mail]
+public class NoSuchCarbonTableException extends MalformedCarbonCommandException {
+  public NoSuchCarbonTableException(String db, String table) {
 
 Review comment:
   @qiuchenjian ..
   1. Carbon in one of the component integrated with spark just like hive and we can multiple components integrated together in one system with spark. In `DDLStratgey` we are just tapping the commands to check for the carbon table. If its a carbon table we give to carbon flow else we give it to spark. We are throwing Malformed exception because spark itself does not support the Alter operation.
   2. Still If you want to change the Malformed exception you can change it to `NoSuchTableExcpetion`. Its a generic exception and should be sufficient.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services