[GitHub] manishnalla1994 commented on a change in pull request #3099: [CARBONDATA-3268] Fix for query on Varchar Columns showing Null in Presto

[GitBox]

manishnalla1994 commented on a change in pull request #3099: [CARBONDATA-3268] Fix for query on Varchar Columns showing Null in Presto
URL: https://github.com/apache/carbondata/pull/3099#discussion_r251284918
 
 

 ##########
 File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
 ##########
 @@ -83,28 +84,45 @@ class PrestoTestNonTransactionalTableFiles extends FunSuiteLike with BeforeAndAf
     prestoServer
       .execute(
         "create table sdk_output.files(name varchar, age int, id tinyint, height double, salary " +
-        "real) with" +
+        "real, address varchar) with" +
         "(format='CARBON') ")
   }
 
-  def buildTestData(rows: Int, options: util.Map[String, String]): Any = {
-    buildTestData(rows, options, List("name"))
+  def buildTestData(rows: Int, options: util.Map[String, String], varcharDataGen: Boolean): Any = {
+    buildTestData(rows, options, List("name"), varcharDataGen)
   }
 
   // prepare sdk writer output
   def buildTestData(rows: Int,
       options: util.Map[String, String],
-      sortColumns: List[String]): Any = {
+      sortColumns: List[String],
+      varcharDataGen: Boolean): Any = {
     val schema = new StringBuilder()
       .append("[ \n")
       .append("   {\"NaMe\":\"string\"},\n")
       .append("   {\"age\":\"int\"},\n")
       .append("   {\"id\":\"byte\"},\n")
       .append("   {\"height\":\"double\"},\n")
-      .append("   {\"salary\":\"float\"}\n")
+      .append("   {\"salary\":\"float\"},\n")
+      .append("   {\"address\":\"varchar\"}\n")
       .append("]")
       .toString()
 
+    // Build Varchar Column data
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services