[GitHub] qiuchenjian commented on a change in pull request #3079: [CARBONDATA-3255]Support binary data type

[GitBox]

qiuchenjian commented on a change in pull request #3079: [CARBONDATA-3255]Support binary data type
URL: https://github.com/apache/carbondata/pull/3079#discussion_r248637655
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
 ##########
 @@ -182,7 +183,11 @@
       } else {
         page = ColumnPage.newPage(columnPageEncoderMeta, pageSize);
       }
-      page.setStatsCollector(PrimitivePageStatsCollector.newInstance(dataTypes[i]));
+      if (dataTypes[i] != DataTypes.BINARY) {
+        page.setStatsCollector(PrimitivePageStatsCollector.newInstance(dataTypes[i]));
+      } else {
+        page.setStatsCollector(new DummyStatsCollector());
+      }
       measurePages[i] = page;
     }
 
 
 Review comment:
   better to update the document, such as "Following Data Types are not Supported for Local Dictionary"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services