[GitHub] qiuchenjian commented on a change in pull request #3079: [CARBONDATA-3255]Support binary data type

[GitBox]

qiuchenjian commented on a change in pull request #3079: [CARBONDATA-3255]Support binary data type
URL: https://github.com/apache/carbondata/pull/3079#discussion_r248648145
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
 ##########
 @@ -287,6 +296,53 @@ private static VarLengthColumnPageBase getVarLengthColumnPage(TableSpec.ColumnSp
     return page;
   }
 
+  private static ColumnPage getBinaryColumnPage(TableSpec.ColumnSpec columnSpec,
+      byte[] lvEncodedBytes, DataType dataType, int start, int len) throws MemoryException {
+    // extract length and data, set them to rowOffset and unsafe memory correspondingly
+    int rowId = 0;
+
+    ColumnPage rowOffset = ColumnPage.newPage(
+        new ColumnPageEncoderMeta(columnSpec, dataType, null),
+        CarbonV3DataFormatConstants.NUMBER_OF_ROWS_PER_BLOCKLET_COLUMN_PAGE_DEFAULT);
+
+    List<Integer> rowLength = new ArrayList<>();
+    int length;
+    int offset;
+    int lvEncodedOffset = start;
+    int counter = 0;
 
 Review comment:
   i think rowId,numRows,counter can be replaced by rowLeng.() or just remain only one , because it's messy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services