[GitHub] qiuchenjian commented on a change in pull request #3091: [CARBONDATA-2447] Block update operation on range/list/hash partition table

[GitBox]

qiuchenjian commented on a change in pull request #3091: [CARBONDATA-2447] Block update operation on range/list/hash partition table
URL: https://github.com/apache/carbondata/pull/3091#discussion_r251676703
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
 ##########
 @@ -60,6 +60,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
       return Seq.empty
     }
     val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
+    if (carbonTable.getPartitionInfo != null &&
+      (carbonTable.getPartitionInfo.getPartitionType == PartitionType.RANGE ||
+        carbonTable.getPartitionInfo.getPartitionType == PartitionType.HASH ||
+        carbonTable.getPartitionInfo.getPartitionType == PartitionType.LIST)) {
 
 Review comment:
   @QiangCai  the document doesn't describe the RANGE_INTERVAL and there isn't a test case to test RANGE_INTERVAL, so i didn't find the scene of RANGE_INTERVAL and no one use this parameter
   was it discarded?   need it to add this check ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services