[GitHub] qiuchenjian commented on a change in pull request #3091: [CARBONDATA-2447] Throw UnsupportedOperationException when update range, hash or list partition table

[GitBox]

qiuchenjian commented on a change in pull request #3091: [CARBONDATA-2447] Throw UnsupportedOperationException when update range,hash or list partition table
URL: https://github.com/apache/carbondata/pull/3091#discussion_r250441829
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
 ##########
 @@ -60,6 +60,13 @@ private[sql] case class CarbonProjectForUpdateCommand(
       return Seq.empty
     }
     val carbonTable = CarbonEnv.getCarbonTable(databaseNameOp, tableName)(sparkSession)
+    if (carbonTable.getPartitionInfo != null &&
+      (carbonTable.getPartitionInfo.getPartitionType == PartitionType.RANGE ||
+        carbonTable.getPartitionInfo.getPartitionType == PartitionType.HASH ||
+        carbonTable.getPartitionInfo.getPartitionType == PartitionType.LIST)) {
 
 Review comment:
   i think ordinal is not a good choice, because others may insert the enum and will not consider the ordinal,  right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services