[GitHub] qiuchenjian commented on a change in pull request #3107: [WIP][Test][CARBONDATA-3271] Provide python SDK for reading CarbonData from S3

[GitBox]

qiuchenjian commented on a change in pull request #3107: [WIP][Test][CARBONDATA-3271] Provide python SDK for reading CarbonData from S3
URL: https://github.com/apache/carbondata/pull/3107#discussion_r251304627
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java
 ##########
 @@ -86,6 +86,8 @@ public double getDouble(int rowId) {
       return converter.decodeDouble(columnPage.getFloat(rowId));
     } else if (dataType == DataTypes.DOUBLE) {
       return columnPage.getDouble(rowId);
+    } else if (dataType == DataTypes.BINARY) {
 
 Review comment:
   Do getDecimal and getLong need to add this branch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services