[GitHub] qiuchenjian commented on a change in pull request #3110: [HOTFIX] Upgraded jars to work S3 with presto

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] qiuchenjian commented on a change in pull request #3110: [HOTFIX] Upgraded jars to work S3 with presto

GitBox
qiuchenjian commented on a change in pull request #3110: [HOTFIX] Upgraded jars to work S3 with presto
URL: https://github.com/apache/carbondata/pull/3110#discussion_r251659448
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
 ##########
 @@ -655,7 +655,7 @@ private long getEndTimeOfDeltaFile(String extension, SegmentUpdateDetails block)
     // get the updated status file identifier from the table status.
     String tableUpdateStatusIdentifier = getUpdatedStatusIdentifier();
 
-    if (null == tableUpdateStatusIdentifier) {
+    if (null == tableUpdateStatusIdentifier || tableUpdateStatusIdentifier.length() == 0) {
 
 Review comment:
   StringUtils.isNotEmpty is better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services