[GitHub] qiuchenjian commented on a change in pull request #3113: [CARBONDATA-3284] [CARBONDATA-3285] Workaround for Create-PreAgg Datamap Fail & Sort-Columns Fix

[GitBox]

qiuchenjian commented on a change in pull request #3113: [CARBONDATA-3284] [CARBONDATA-3285] Workaround for Create-PreAgg Datamap Fail & Sort-Columns Fix
URL: https://github.com/apache/carbondata/pull/3113#discussion_r253243631
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
 ##########
 @@ -77,7 +77,37 @@ case class CarbonDropTableCommand(
       }
       val relationIdentifiers = carbonTable.getTableInfo.getParentRelationIdentifiers
       if (relationIdentifiers != null && !relationIdentifiers.isEmpty) {
-        if (!dropChildTable) {
+        var ignoreParentTableCheck = false
+        if (carbonTable.getTableInfo.getParentRelationIdentifiers.size() == 1) {
+          // below handling in case when pre aggregation creation failed in below scenario
+          // while creating a pre aggregate data map it created pre aggregate table and registered
+          // in hive, but failed to register in main table because of some exception.
+          // in this case if it will not allow user to drop datamap and data map table
+          // for this if user run drop table command for pre aggregate it should allow user to drop
+          // the same
+          val parentDbName = carbonTable.getTableInfo.getParentRelationIdentifiers.get(0)
 
 Review comment:
   better to add some logs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services