[GitHub] qiuchenjian commented on a change in pull request #3116: [CARBONDATA-3229]Validate the true/false for all boolean parameters

[GitBox]

qiuchenjian commented on a change in pull request #3116: [CARBONDATA-3229]Validate the true/false for all boolean parameters
URL: https://github.com/apache/carbondata/pull/3116#discussion_r252087214
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
 ##########
 @@ -99,6 +65,11 @@
    */
   private Map<String, String> addedProperty = new ConcurrentHashMap<>();
 
+  /**
+   * Boolean type properties default value
+   */
+  Map<String, String> booleanProperties = new ConcurrentHashMap<>();
 
 Review comment:
   why is the modifier "package", better to change to private

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services