[GitHub] qiuchenjian commented on a change in pull request #3133: [CARBONDATA-3301]Fix inserting null values to Array<date> columns in carbon file format data load

[GitBox]

qiuchenjian commented on a change in pull request #3133: [CARBONDATA-3301]Fix inserting null values to Array<date>  columns in carbon file format data load
URL: https://github.com/apache/carbondata/pull/3133#discussion_r259554559
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
 ##########
 @@ -344,7 +344,7 @@ public int getSurrogateIndex() {
             byte[] value = null;
             if (isDirectDictionary) {
               int surrogateKey;
-              if (!(input instanceof Long)) {
+              if (!(input instanceof Long) && !(input instanceof Integer)) {
 
 Review comment:
   Does other datatype have the same problem?  such as short, byte

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services