[GitHub] ravipesala commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue

[GitBox]

ravipesala commented on a change in pull request #3096: [WIP]Fixed Range Sort OOM Issue
URL: https://github.com/apache/carbondata/pull/3096#discussion_r250224598
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/sort/impl/UnsafeParallelReadMergeSorterImpl.java
 ##########
 @@ -85,7 +85,9 @@ public UnsafeParallelReadMergeSorterImpl(AtomicLong rowCounter) {
     } catch (Exception e) {
       throw new CarbonDataLoadingException(e);
     }
-    this.executorService = Executors.newFixedThreadPool(iterators.length,
+    // setting the number of cores to 1 in case of range sort
+    int numberOfCores = sortParameters.isRangeSort() ? 1 : iterators.length;
 
 Review comment:
   I think for range sort iterators length is always one so no need have this condition

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services