ravipesala commented on a change in pull request #3121: [CARBONDATA-3287]Remove the validation for same schema in a location and fix drop datamap issue
URL:
https://github.com/apache/carbondata/pull/3121#discussion_r254146114
##########
File path: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java
##########
@@ -80,10 +83,11 @@
/**
* It is called to initialize and load the required table datamap metadata.
*/
- TableDataMap(AbsoluteTableIdentifier identifier, DataMapSchema dataMapSchema,
+ TableDataMap(CarbonTable table, DataMapSchema dataMapSchema,
Review comment:
How could you make sure carbontable is updated here whenever any changes happens to schema of table if you pass it to the constructor. Because TableDataMap is cached and it would not be created every time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
